Skip to content

Fix several compilation warnings #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gilbertwong96 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix several compilation warnings #437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
de0e5d7
Fix several compilation warnings
gilbertwong96 Jun 30, 2026
7d2f4a1
Tighten CI matrix to maintained Elixir versions
gilbertwong96 Jun 30, 2026
b2542b7
Bump minimum Elixir to 1.16 and pin CI jobs to 1.20
gilbertwong96 Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 5 additions & 13 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,19 +16,11 @@ jobs:
fail-fast: false
matrix:
elixir:
- '1.20'
- '1.19'
- '1.18'
- '1.17'
- '1.16'
- '1.15'
- '1.14'
- '1.13'
- '1.12'
- '1.11'
- '1.10'
- '1.9'
- '1.8'
- '1.7'

steps:
- uses: actions/checkout@v4
Expand All @@ -48,7 +40,7 @@ jobs:
name: Benchmark
runs-on: ubuntu-latest
container:
image: elixir:1.19
image: elixir:1.20
steps:
- uses: actions/checkout@v4

Expand All @@ -66,7 +58,7 @@ jobs:
name: Coverage
runs-on: ubuntu-latest
container:
image: elixir:1.19
image: elixir:1.20
env:
MIX_ENV: cover
steps:
Expand All @@ -88,7 +80,7 @@ jobs:
name: Documentation
runs-on: ubuntu-latest
container:
image: elixir:1.19
image: elixir:1.20
steps:
- uses: actions/checkout@v4

Expand All @@ -112,7 +104,7 @@ jobs:
name: Linting
runs-on: ubuntu-latest
container:
image: elixir:1.19
image: elixir:1.20
steps:
- uses: actions/checkout@v4

Expand Down
1 change: 0 additions & 1 deletion lib/cachex.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ defmodule Cachex do

# import util macros
require Router
require Overseer

# avoid inspect clashes
import Kernel, except: [inspect: 2]
Expand Down
4 changes: 2 additions & 2 deletions lib/cachex/spec/validator.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ defmodule Cachex.Spec.Validator do
import Cachex.Spec

# internal spec to refer to each record type
@type record ::
@type spec_record ::
Cachex.Spec.command()
| Cachex.Spec.entry()
| Cachex.Spec.expiration()
Expand All @@ -31,7 +31,7 @@ defmodule Cachex.Spec.Validator do

This will delegate each record type to a customized validation function.
"""
@spec valid?(atom, record) :: boolean
@spec valid?(atom, spec_record) :: boolean

# Validates a command specification record.
#
Expand Down
17 changes: 11 additions & 6 deletions mix.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ defmodule Cachex.Mixfile do
maintainers: ["Isaac Whitfield"]
},
version: @version,
elixir: "~> 1.7",
elixir: "~> 1.16",
deps: deps(),
docs: [
main: "overview",
Expand Down Expand Up @@ -61,18 +61,23 @@ defmodule Cachex.Mixfile do
test_coverage: [
tool: ExCoveralls
],
preferred_cli_env: [
aliases: [
bench: "run benchmarks/main.exs",
test: [&start_epmd/1, "test"]
]
]
end

def cli do
[
preferred_envs: [
docs: :docs,
bench: :bench,
credo: :lint,
cachex: :test,
coveralls: :cover,
"coveralls.html": :cover,
"coveralls.travis": :cover
],
aliases: [
bench: "run benchmarks/main.exs",
test: [&start_epmd/1, "test"]
]
]
end
Expand Down