Fix top nav for small viewports#920
Merged
Merged
Conversation
|
A preview of this PR is available at https://pr-920-wildfly-org.surge.sh |
jasondlee
approved these changes
Jun 25, 2026
- Fix top nav for viewports lower than 1570px - Change .nav-list from position:relative to position:absolute so the hamburger menu overlays page content instead of pushing it down - Prevent auto-hide of nav bar while the menu is open to stop the menu from sliding off-screen on scroll - Rename main.js to index.js so the Quarkus Web Bundler includes JS in the dev bundle (no production impact)
Contributor
Author
|
I fixed a few more things while doing local tests:
|
rhusar
approved these changes
Jun 29, 2026
rhusar
left a comment
rhusar
left a comment
Member
There was a problem hiding this comment.
LGTM, I was able to reproduce the issue on https://www.wildfly.org/ and I see it fixed in here.
Member
|
Thanks @hpehl and @jasondlee |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Links in the top navigation flow out of their container for small viewport sizes.
This PR fixes this by setting the
overflowCSS property.