Skip to content

Jacob/feat/acquisition flow bindings#2074

Merged
typfel merged 5 commits into
mainfrom
jacob/feat/acqusition-flow-bindings
May 6, 2026
Merged

Jacob/feat/acquisition flow bindings#2074
typfel merged 5 commits into
mainfrom
jacob/feat/acqusition-flow-bindings

Conversation

@typfel
Copy link
Copy Markdown
Member

@typfel typfel commented Apr 24, 2026

What's new in this PR

Expose the acquisition flow in the bindings


PR Submission Checklist for internal contributors
  • The PR Title
    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@typfel typfel requested a review from a team April 24, 2026 11:07
Comment thread crypto-ffi/src/e2ei/mod.rs Outdated
Comment thread crypto-ffi/src/e2ei/mod.rs Outdated
Comment thread crypto-ffi/src/e2ei/mod.rs Outdated
Comment thread crypto-ffi/src/e2ei/mod.rs Outdated
Comment thread crypto-ffi/src/e2ei/mod.rs Outdated
Comment thread crypto-ffi/src/e2ei/mod.rs Outdated
Comment thread crypto-ffi/src/e2ei/mod.rs Outdated
@typfel typfel force-pushed the jacob/feat/acqusition-flow-bindings branch 5 times, most recently from b26da68 to cb299bb Compare April 28, 2026 07:25
@typfel typfel requested a review from istankovic April 28, 2026 09:00
Copy link
Copy Markdown
Contributor

@fewerner fewerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just merged the ts-browser util changes. You can now access window.helpers to get util from within the browser context.

Comment thread crypto-ffi/bindings/js/packages/browser/test/e2ei.test.ts Outdated
Comment thread crypto-ffi/bindings/js/packages/browser/test/e2ei.test.ts Outdated
@typfel typfel force-pushed the jacob/feat/acqusition-flow-bindings branch from c8be0a4 to 7d2fd34 Compare April 28, 2026 14:52
@typfel typfel requested a review from fewerner April 28, 2026 15:19
@typfel typfel force-pushed the jacob/feat/acqusition-flow-bindings branch 2 times, most recently from 095d722 to 4c5350f Compare May 6, 2026 06:56
Comment thread crypto-ffi/src/e2ei/mod.rs
@istankovic
Copy link
Copy Markdown
Member

I think this looks good overall, but I would just like to clarify the situation around that Arc holding the client ID.

@typfel typfel requested a review from istankovic May 6, 2026 08:49
Copy link
Copy Markdown
Member

@istankovic istankovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@typfel typfel force-pushed the jacob/feat/acqusition-flow-bindings branch from 4c5350f to 74e0258 Compare May 6, 2026 09:12
@typfel typfel force-pushed the jacob/feat/acqusition-flow-bindings branch from 74e0258 to 47ad535 Compare May 6, 2026 09:32
@typfel typfel merged commit 47ad535 into main May 6, 2026
33 checks passed
@typfel typfel deleted the jacob/feat/acqusition-flow-bindings branch May 6, 2026 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants