Skip to content

fix: inconsistent copy re: groups vs conversation - WPB-24863#4603

Merged
johnxnguyen merged 3 commits into
developfrom
fix/inconsistent-copy-wpb-24863
May 4, 2026
Merged

fix: inconsistent copy re: groups vs conversation - WPB-24863#4603
johnxnguyen merged 3 commits into
developfrom
fix/inconsistent-copy-wpb-24863

Conversation

@johnxnguyen
Copy link
Copy Markdown
Collaborator

@johnxnguyen johnxnguyen commented Apr 21, 2026

BugWPB-24863 [iOS] [Groups] Naming is inconsistent when deleting or leaving a group by user

Issue

There is some inconsistent copy concerning groups and conversations, in particular when deleting a conversation. For instance, the action to delete the conversation has the label Delete conversation and tapping it results in a confirmation alert that asks Delete group?.

This PR adjusts the copy to align the terminology toward conversation instead of group, in the alert confirmation and also in the description of the admin.

Testing

  1. Open app
  2. Navigate to a team group conversation that you have created
  3. Go to conversation details
  4. Tap on the ... button in the foot, then "Delete conversation"
  5. Assert the copy says "conversation" instead of "group".
Simulator Screenshot - A - 2026-04-21 at 11 40 35

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 21, 2026

Test Results

1 881 tests   1 854 ✅  2m 10s ⏱️
  301 suites     27 💤
    1 files        0 ❌

Results for commit 547a8bf.

♻️ This comment has been updated with latest results.

Summary: workflow run #25326448476

@datadog-wireapp
Copy link
Copy Markdown

datadog-wireapp Bot commented Apr 21, 2026

Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 547a8bf | Docs | Give us feedback!

Copy link
Copy Markdown
Contributor

@samwyndham samwyndham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnxnguyen johnxnguyen enabled auto-merge May 4, 2026 15:01
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 4, 2026

@johnxnguyen johnxnguyen added this pull request to the merge queue May 4, 2026
Merged via the queue into develop with commit 93d1c08 May 4, 2026
13 checks passed
@johnxnguyen johnxnguyen deleted the fix/inconsistent-copy-wpb-24863 branch May 4, 2026 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants