fix: channels filter visible when channel feature disabled - WPB-24857#4608
Merged
Conversation
Contributor
Test Results2 141 tests 2 113 ✅ 3m 34s ⏱️ Results for commit ea303bc. ♻️ This comment has been updated with latest results. Summary: workflow run #25421005044 |
caldrian
approved these changes
Apr 24, 2026
…re-ios into fix/channels-filter-wpb-24857
|
6 tasks
johnxnguyen
added a commit
that referenced
this pull request
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Issue
Even when channels is disabled for the user, they are able to see the channel filter (from filter menu in iOS and Split View sidebar on iPadOS).
This PR conditionally shows the channels filter depending on the channels feature config state.
Testing
Log in to an account that doesn't have channels, assert no filter for channels is visible (both iPhone and iPad):

Log in to an account that does have channels, assert there is a filter for channels visible (both iPhone and iPad):

Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: