Skip to content

fix: channels filter visible when channel feature disabled - WPB-24857#4608

Merged
johnxnguyen merged 7 commits into
release/cycle-4.16from
fix/channels-filter-wpb-24857
May 6, 2026
Merged

fix: channels filter visible when channel feature disabled - WPB-24857#4608
johnxnguyen merged 7 commits into
release/cycle-4.16from
fix/channels-filter-wpb-24857

Conversation

@johnxnguyen

@johnxnguyen johnxnguyen commented Apr 21, 2026

Copy link
Copy Markdown
Collaborator
BugWPB-24857 [iOS] [Filters] Unsupported channels appear when selecting filters by user

Issue

Even when channels is disabled for the user, they are able to see the channel filter (from filter menu in iOS and Split View sidebar on iPadOS).

This PR conditionally shows the channels filter depending on the channels feature config state.

Testing

Log in to an account that doesn't have channels, assert no filter for channels is visible (both iPhone and iPad):
Simulator Screenshot - A - 2026-04-21 at 16 59 58

Log in to an account that does have channels, assert there is a filter for channels visible (both iPhone and iPad):
Simulator Screenshot - A - 2026-04-21 at 16 59 47


Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@johnxnguyen johnxnguyen changed the title Fix: channels filter visible when channel feature disabled - WPB-24857 fix: channels filter visible when channel feature disabled - WPB-24857 Apr 21, 2026
@github-actions

github-actions Bot commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

Test Results

2 141 tests   2 113 ✅  3m 34s ⏱️
  363 suites     28 💤
    3 files        0 ❌

Results for commit ea303bc.

♻️ This comment has been updated with latest results.

Summary: workflow run #25421005044
Allure report (download zip): html-report-29765-fix_channels-filter-wpb-24857

@datadog-wireapp

datadog-wireapp Bot commented Apr 21, 2026

Copy link
Copy Markdown

Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 16dcddb | Docs | Give us feedback!

@jullianm jullianm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnxnguyen johnxnguyen enabled auto-merge (squash) May 6, 2026 06:56
@sonarqubecloud

sonarqubecloud Bot commented May 6, 2026

Copy link
Copy Markdown

@johnxnguyen johnxnguyen merged commit 811b97e into release/cycle-4.16 May 6, 2026
13 checks passed
@johnxnguyen johnxnguyen deleted the fix/channels-filter-wpb-24857 branch May 6, 2026 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants