fix: 2FA code request error alert - WPB-24847#4609
Merged
Conversation
Contributor
Test Results 7 files 775 suites 5m 50s ⏱️ Results for commit 01a8551. ♻️ This comment has been updated with latest results. Summary: workflow run #25794122136 |
netbe
approved these changes
Apr 22, 2026
Collaborator
netbe
left a comment
netbe
left a comment
There was a problem hiding this comment.
lgtm:) left a few comments
David-Henner
approved these changes
Apr 28, 2026
|
6 tasks
johnxnguyen
added a commit
that referenced
this pull request
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
2FA codes from the backend can only be requested once within a time interval. If the code is requested multiple times in within the interval it will return a 429 "too many request" error.
This error is not handled in any particular way and is surfaced to the error as a generic "something went wrong" alert which confuses the user.
Simulator.Screen.Recording.-.A.-.2026-04-21.at.23.48.37.mov
This PR improves the error handling to better inform the user what is going on by disabling the button to request a new code and showing the number of seconds until a new code can be requested.
Simulator.Screen.Recording.-.A.-.2026-05-13.at.10.53.03.mov
Simulator.Screen.Recording.-.A.-.2026-05-13.at.10.58.14.mov
Testing
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: