Skip to content

fix: disable file tracker when restoring file - WPB-25021#4643

Merged
jullianm merged 3 commits intodevelopfrom
fix/restore-file-version-opens-many-times
May 4, 2026
Merged

fix: disable file tracker when restoring file - WPB-25021#4643
jullianm merged 3 commits intodevelopfrom
fix/restore-file-version-opens-many-times

Conversation

@jullianm
Copy link
Copy Markdown
Contributor

@jullianm jullianm commented Apr 27, 2026

BugWPB-25021 [iOS] Restoring a File Version causes multiple openings

Issue

Fixes an issue where restoring a file would trigger multiple file openings. The root cause is that when fetching the URL of a file, we also send updates to a Combine's subject which is observed from the main Files view, which in turn triggers opening the asset using the file tracker.
Solution here was to temporarily disable the file tracker when restoring a file as file tracking is not necessary when restoring a file.

Testing

  • go to version history on a file (context menu)
  • restore a version, observe that the asset is opened once (file tracker disabled)
  • go back to files view, tap on multiple files, observe that assets are downloaded and UI states correctly shown (file tracking enabled)

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@jullianm jullianm requested a review from caldrian April 27, 2026 09:53
@jullianm jullianm requested review from KaterinaWire, WilhelmOks and caldrian and removed request for caldrian April 27, 2026 09:53
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 27, 2026

Test Results

294 tests   294 ✅  1m 49s ⏱️
 55 suites    0 💤
  1 files      0 ❌

Results for commit 93ffbd6.

♻️ This comment has been updated with latest results.

Summary: workflow run #24993321359
Allure report (download zip): html-report-29561-fix_restore-file-version-opens-many-times

@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Collaborator

@WilhelmOks WilhelmOks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't particularly like this solution but I have no better idea how to solve this.

@jullianm jullianm added this pull request to the merge queue May 4, 2026
Merged via the queue into develop with commit 6d41f23 May 4, 2026
13 checks passed
@jullianm jullianm deleted the fix/restore-file-version-opens-many-times branch May 4, 2026 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants