Skip to content

fix: links aren't shared via share extension - WPB-24816#4663

Merged
johnxnguyen merged 1 commit into
developfrom
fix/sharing-links-wpb-24816
May 4, 2026
Merged

fix: links aren't shared via share extension - WPB-24816#4663
johnxnguyen merged 1 commit into
developfrom
fix/sharing-links-wpb-24816

Conversation

@johnxnguyen

@johnxnguyen johnxnguyen commented Apr 30, 2026

Copy link
Copy Markdown
Collaborator
BugWPB-24816 [iOS] [Share ext] Sharing website from Safari doesn't include link

Issue

When sharing a webpage via the share extension (such as from Safari) only the webpage title is included in the message and not the link.

This is because the webpage is the default text content and we must extract the url and append it to the text content, but a change introduced in #3373 causes the attachments to be loaded later than usual due to being put inside a Task. As a result, when the view appears and we check to append any possible urls, there are no attachments loaded yet and nothing is appended.

The solution is to move the loading of attachments outside of the Task (it's not necessary to have it in the task) so that it is done synchronously before the view appears.

Testing

  1. Be logged in.
  2. Open safari and try to share a webpage, such as www.apple.com
  3. Before sending the message, assert that the text content includes the link.
  4. Send the message, and check in the main app (sender or receiver) that the link is included in the sent message.

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@github-actions

github-actions Bot commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Test Results

1 881 tests   1 854 ✅  2m 2s ⏱️
  301 suites     27 💤
    1 files        0 ❌

Results for commit 7cd2c34.

♻️ This comment has been updated with latest results.

Summary: workflow run #25310888647
Allure report (download zip): html-report-29657-fix_sharing-links-wpb-24816

@netbe netbe left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:)

@johnxnguyen johnxnguyen changed the base branch from release/cycle-4.18 to develop May 4, 2026 09:00
@johnxnguyen johnxnguyen force-pushed the fix/sharing-links-wpb-24816 branch from d6fa5ba to 3b7e708 Compare May 4, 2026 09:12
@johnxnguyen johnxnguyen force-pushed the fix/sharing-links-wpb-24816 branch from 3b7e708 to 7cd2c34 Compare May 4, 2026 09:14
@johnxnguyen johnxnguyen enabled auto-merge May 4, 2026 09:14
@sonarqubecloud

sonarqubecloud Bot commented May 4, 2026

Copy link
Copy Markdown

@johnxnguyen johnxnguyen added this pull request to the merge queue May 4, 2026
Merged via the queue into develop with commit 4c98afb May 4, 2026
13 checks passed
@johnxnguyen johnxnguyen deleted the fix/sharing-links-wpb-24816 branch May 4, 2026 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants