fix: links aren't shared via share extension - WPB-24816#4663
Merged
Conversation
samwyndham
approved these changes
Apr 30, 2026
Contributor
Test Results1 881 tests 1 854 ✅ 2m 2s ⏱️ Results for commit 7cd2c34. ♻️ This comment has been updated with latest results. Summary: workflow run #25310888647 |
d6fa5ba to
3b7e708
Compare
3b7e708 to
7cd2c34
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Issue
When sharing a webpage via the share extension (such as from Safari) only the webpage title is included in the message and not the link.
This is because the webpage is the default text content and we must extract the url and append it to the text content, but a change introduced in #3373 causes the attachments to be loaded later than usual due to being put inside a
Task. As a result, when the view appears and we check to append any possible urls, there are no attachments loaded yet and nothing is appended.The solution is to move the loading of attachments outside of the Task (it's not necessary to have it in the task) so that it is done synchronously before the view appears.
Testing
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: