fix: mentions rendered incorrectly - WPB-21687

[johnxnguyen]

WPB-21687 [iOS] Mentioned replaces first letter of name with '@'

Issue

It has been observed that in some cases mentions are rendered incorrectly, as shown here:

It's suspected that this is due to the sender of the text message incorrectly calculating the range of the mention to only include the name and not the the @ prefix. For instance, in the message Hello @Bruno! How are you? the mention range that is sent in the protobuf message should be location 6 with length 6 (encompassing @Bruno). But if instead the mention range is location 7 length 5 (encompassing Bruno) then the iOS app will render the mention incorrectly as shown in the previous attachment.

This PR accounts for this hypothetical case by checking if the mention range includes the prefix @. If it does not, it will check that the string has a @ prefix available and if it does will adjust the mention range to encompass also this @ prefix. Then it proceeds as normal with the mention rendering. The result is:

Testing

Since it is not know how to reproduce this hypothetical case, there are no steps. However it seems to have something to do with copying and pasting a message containing mentions on the web app and sending the message, then editing the message to apply the mentions.

---

Checklist

• Title contains a reference JIRA issue number like [WPB-XXX].
• Description is filled and free of optional paragraphs.
• Adds/updates automated tests.

---

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

• Make sure you use the API for UI elements that support large fonts.
• All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
• New UI elements have Accessibility strings for VoiceOver.

[github-actions]

Test Results

1 883 tests   1 855 ✅  2m 11s ⏱️
  301 suites     27 💤
    1 files        1 ❌

For more details on these failures, see this check.

Results for commit 5ac135c.

♻️ This comment has been updated with latest results.

Summary: workflow run #25311515090
Allure report (download zip): html-report-29661-fix_mention-rendering-wpb-21687

[datadog-wireapp]

✨ Fix all issues with Cursor

⚠️ Warnings

🧪 1 Test failed

testThatItUsesCorrectUTF16OffsetForMention() from Wire-iOS-Tests.Message_FormattingTests     (Fix with Cursor)

Test crashed with signal trap.

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 5ac135c | Docs | Give us feedback!}

[samwyndham]

It looks good but I'm torn to whether this fix should be done on iOS if it really is a bug coming from web. Perhaps we could consider this a temporary fix and add some additional logging to help identify the underlying issue. Is Android not affected by the bug also?

[johnxnguyen]

It looks good but I'm torn to whether this fix should be done on iOS if it really is a bug coming from web. Perhaps we could consider this a temporary fix and add some additional logging to help identify the underlying issue. Is Android not affected by the bug also?

Yes I also agree with you, but I can try to raise it with the web team but I don't know how quickly they would be able to address it. I'll keep it open for now and see if we can at least verify that the bug may be coming from their side.

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud