-
Notifications
You must be signed in to change notification settings - Fork 38
feat: show open mainapp notification - WPB-25768 #4786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
651b355
show main app notification
netbe 3c22b74
code reveiew
netbe 2445873
one flag
netbe 8bcb01a
fix flag for testing
netbe bc669c4
replace wording
netbe ef6964f
Merge branch 'develop' into feat/show-open-mainapp-WPB-25768
netbe b1e3d0d
Merge branch 'develop' into feat/show-open-mainapp-WPB-25768
netbe 2b856d7
code review
netbe 3f8689c
update tests
netbe c311a70
Merge branch 'feat/show-open-mainapp-WPB-25768' of github.com:wireapp…
netbe 9eb56e3
format
netbe 015879b
Merge branch 'develop' into feat/show-open-mainapp-WPB-25768
netbe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
59 changes: 59 additions & 0 deletions
59
WireDomain/Sources/WireDomain/Notifications/MainAppRequiredGate.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| // | ||
| // Wire | ||
| // Copyright (C) 2026 Wire Swiss GmbH | ||
| // | ||
| // This program is free software: you can redistribute it and/or modify | ||
| // it under the terms of the GNU General Public License as published by | ||
| // the Free Software Foundation, either version 3 of the License, or | ||
| // (at your option) any later version. | ||
| // | ||
| // This program is distributed in the hope that it will be useful, | ||
| // but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| // GNU General Public License for more details. | ||
| // | ||
| // You should have received a copy of the GNU General Public License | ||
| // along with this program. If not, see http://www.gnu.org/licenses/. | ||
| // | ||
|
|
||
| import Foundation | ||
|
|
||
| struct MainAppRequiredGate { | ||
|
|
||
| static let defaultInterval: TimeInterval = 60 * 60 | ||
|
|
||
| private let userDefaults: UserDefaults | ||
| private let interval: TimeInterval | ||
|
|
||
| init( | ||
| userDefaults: UserDefaults, | ||
| interval: TimeInterval = defaultInterval | ||
| ) { | ||
| self.userDefaults = userDefaults | ||
| self.interval = interval | ||
| } | ||
|
|
||
| func markNotified(accountID: UUID, now: Date = .now) { | ||
| let journal = Journal(userID: accountID, storage: userDefaults) | ||
| journal[.mainAppRequiredNotificationLastNotifiedDate] = now | ||
| } | ||
|
|
||
| func shouldNotify(accountID: UUID, now: Date = .now) -> Bool { | ||
| let journal = Journal(userID: accountID, storage: userDefaults) | ||
|
|
||
| guard let lastNotifiedDate = journal[.mainAppRequiredNotificationLastNotifiedDate] else { | ||
| return true | ||
| } | ||
|
|
||
| return now.timeIntervalSince(lastNotifiedDate) >= interval | ||
| } | ||
|
|
||
| static func isMainAppRequiredErrorFoAccount(_ error: any Error) -> UUID? { | ||
| guard let nseUserError = error as? NSEUserScope.Failure, | ||
| case let .mainAppRequired(_, accountID) = nseUserError else { | ||
| return nil | ||
| } | ||
|
|
||
| return accountID | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
80 changes: 80 additions & 0 deletions
80
WireDomain/Tests/WireDomainTests/Notifications/MainAppRequiredGateTests.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,80 @@ | ||
| // | ||
| // Wire | ||
| // Copyright (C) 2026 Wire Swiss GmbH | ||
| // | ||
| // This program is free software: you can redistribute it and/or modify | ||
| // it under the terms of the GNU General Public License as published by | ||
| // the Free Software Foundation, either version 3 of the License, or | ||
| // (at your option) any later version. | ||
| // | ||
| // This program is distributed in the hope that it will be useful, | ||
| // but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| // GNU General Public License for more details. | ||
| // | ||
| // You should have received a copy of the GNU General Public License | ||
| // along with this program. If not, see http://www.gnu.org/licenses/. | ||
| // | ||
|
|
||
| import Foundation | ||
| import Testing | ||
| import WireSystem | ||
| @testable import WireDomain | ||
|
|
||
| struct MainAppRequiredGateTests { | ||
| private let userDefaults = UserDefaults.temporary() | ||
| private let accountID = UUID() | ||
|
|
||
| private var sut: MainAppRequiredGate { | ||
| MainAppRequiredGate(userDefaults: userDefaults) | ||
| } | ||
|
|
||
| @Test("It notifies on first main-app-required error") | ||
| func notifiesOnFirstMainAppRequiredError() { | ||
| #expect(sut.shouldNotify(accountID: accountID, now: Date(timeIntervalSince1970: 1000))) | ||
| } | ||
|
|
||
| @Test("It suppresses notifications within one hour") | ||
| func suppressesNotificationsWithinOneHour() { | ||
| let now = Date(timeIntervalSince1970: 2000) | ||
|
|
||
| sut.markNotified(accountID: accountID, now: now) | ||
|
|
||
| #expect(!sut.shouldNotify(accountID: accountID, now: now.addingTimeInterval(3599))) | ||
| } | ||
|
|
||
| @Test("It notifies again after one hour") | ||
| func notifiesAgainAfterOneHour() { | ||
| let now = Date(timeIntervalSince1970: 2000) | ||
|
|
||
| sut.markNotified(accountID: accountID, now: now) | ||
|
|
||
| #expect(sut.shouldNotify(accountID: accountID, now: now.addingTimeInterval(3600))) | ||
| } | ||
|
|
||
| @Test("It scopes notifications by account") | ||
| func scopesNotificationsByAccount() { | ||
| let now = Date(timeIntervalSince1970: 2000) | ||
| let otherAccountID = UUID() | ||
|
|
||
| sut.markNotified(accountID: accountID, now: now) | ||
|
|
||
| // The marked account is suppressed, but a different account still notifies. | ||
| #expect(!sut.shouldNotify(accountID: accountID, now: now.addingTimeInterval(3599))) | ||
| #expect(sut.shouldNotify(accountID: otherAccountID, now: now.addingTimeInterval(3599))) | ||
| } | ||
|
|
||
| @Test("It extracts the account ID from a main-app-required error") | ||
| func extractsAccountIDFromMainAppRequiredError() { | ||
| let error = NSEUserScope.Failure.mainAppRequired(message: "test", accountID: accountID) | ||
|
|
||
| #expect(MainAppRequiredGate.isMainAppRequiredErrorFoAccount(error) == accountID) | ||
| } | ||
|
|
||
| @Test("It ignores non main-app-required errors") | ||
| func ignoresNonMainAppRequiredErrors() { | ||
| let error = TestError(message: "test") | ||
|
|
||
| #expect(MainAppRequiredGate.isMainAppRequiredErrorFoAccount(error) == nil) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.