Skip to content

fix: e2ei certificate update flow - WPB-24855 🍒#4792

Open
github-actions[bot] wants to merge 1 commit into
developfrom
fix/update-certificate-flow-activity-indicators-cherry-pick
Open

fix: e2ei certificate update flow - WPB-24855 🍒#4792
github-actions[bot] wants to merge 1 commit into
developfrom
fix/update-certificate-flow-activity-indicators-cherry-pick

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot commented Jun 1, 2026

This PR was automatically cherry-picked based on the following PR:

Original PR description:


BugWPB-24855 [iOS] [Security] Certificate renewal delay occurs when renewing expired E2EI certificate by user

Issue

  • The e2ei certificate enrollment flow has no activity indicators between the different steps. Under bad network conditions, it appears as if nothing is happening for a while.
  • The "Update Certificate" popup can be displayed more than once.

Solution

  • Add an activity indicator between each e2ei certificate enrollment flow step
  • Prevent the popup from being shown during the certificate update flow

Changes

  • Introduced LifecycleAwareUserAgent to wrap the different agents conforming to OIDExternalUserAgent and provide callbacks on the agent's presentation and dismissal
  • Introduced E2EIEnrollmentFlow to manage the presentation of activity indicators
  • Updated all the certificate enrollment flows to rely on E2EIEnrollmentFlow for a consistent UX
  • Added a flag in the certificate update flow to prevent showing the "Update Certificate" popup when the flow is ongoing
  • Added a debug action to trigger the "Update Certificate" popup
  • Added tests

Testing

  • Log in with a user in a team with e2ei enabled
  • Use the developer tools to enroll an e2ei certificate with short expiration time
  • Background & foreground the app, the "Update Certificate" popup should appear
  • Verify that the popup doesn't appear more than once when reopening the app
  • Update the certificate and verify that the activity indicators appear before & after the web view

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 1, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant