Skip to content

Fix/miscellaneous (WPB-21440)#21099

Draft
panuschek wants to merge 17 commits intodevfrom
fix/miscellaneous
Draft

Fix/miscellaneous (WPB-21440)#21099
panuschek wants to merge 17 commits intodevfrom
fix/miscellaneous

Conversation

@panuschek
Copy link
Copy Markdown
Collaborator

@panuschek panuschek commented Apr 22, 2026

StoryWPB-21440 [Web] [Integration] Toggle Apps in Conversation Flow

Summary

  • What did I change and why?
  • Risks and how to roll out / roll back (e.g. feature flags):

Security Checklist (required)

  • External inputs are validated & sanitized on client and/or server where applicable.
  • API responses are validated; unexpected shapes are handled safely (fallbacks or errors).
  • No unsafe HTML is rendered; if unavoidable, sanitization is applied and documented where it happens.
  • Injection risks (XSS/SQL/command) are prevented via safe APIs and/or escaping.

Accessibility (required)

Standards Acknowledgement (required)


Screenshots or demo (if the user interface changed)

Notes for reviewers

  • Trade-offs:
  • Follow-ups (linked issues):
  • Linked PRs (e.g. web-packages):

thisisamir98 and others added 17 commits March 31, 2026 10:35
chore: Release 13/04/2026 [WPB-22420]
chore: Update translations [WPB-22420]
chore(E2E): Updated calling service API client to use 1Password [WPB-24489] (#20905)
chore: Release 27/04/2026 [WPB-22420]
chore: Release 27/04/2026 [WPB-22420]
* fixed missing dependency in addParticipants.tsx

* removed MLS exclusion for services in addParticipants.tsx

* update ServiceEntity.ts to contain category

* added service from user mapper

* added app list in addParticipants.tsx

* consolidated services and apps lists in addParticipants.tsx

* added usertype filters in UserSearchableList.tsx

* removed unnecessary usertype filters

* added IntegrationMapper.test.ts

* added skeleton for addParticipants.test.tsx

* test: set up mocks for addParticipants to at least render (#21027)

* remove something

* remove redundant unit test

* fixed missing check on conversation protocol

* streamlined field assignments in ServiceEntity.ts

---------

Co-authored-by: Mark Brockhoff <95471369+markbrockhoff@users.noreply.github.com>
* update ConversationRepository.ts to pick only qualifiedId from userEntites in addUsers

* updated ServiceEntity.ts to include isApp check and qualifiedId

# Conflicts:
#	apps/webapp/src/script/repositories/integration/ServiceEntity.ts

* updated ServiceListItem.tsx to display apps

* updated IntegrationMapper.ts to set qualifiedIds of services

* fix Avatar to allow apps to be displayed as services as well

* fixed mapping of apps as services in RightSidebar.tsx

* review fixes

* reintroduce qualifiedId in IntegrationMapper.ts

* add type field to ServiceEntity.ts

* replaced or with isAppOrServiceEntity
* add fallback to preview image if high res isn't available

* implement app details view in add participants screen

* display apps as services in conversationDetails.tsx

* remove author class in panel-participant-details.less

* fix removing apps from conversations

* implement adding apps to conversations

* add early return instead of nested ifs

* made pushing into the services list more functional

* remove predicate in groupParticipantService.tsx

* add error message in ActionsViewModel.ts

* refactored serviceEntity fetching in conversationDetails.tsx

* explicit null check
@sonarqubecloud
Copy link
Copy Markdown

@panuschek panuschek changed the title Fix/miscellaneous Fix/miscellaneous (WPB-21440) Apr 22, 2026
@markbrockhoff markbrockhoff force-pushed the integrations-2-release branch from 0362d84 to 6434823 Compare April 24, 2026 08:52
Base automatically changed from integrations-2-release to dev April 24, 2026 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants