test: Add missing regression test for editing replies [WPB-24828]#21167
Draft
JacquelineLehner wants to merge 3 commits intodevfrom
Draft
test: Add missing regression test for editing replies [WPB-24828]#21167JacquelineLehner wants to merge 3 commits intodevfrom
JacquelineLehner wants to merge 3 commits intodevfrom
Conversation
This commit completes the regression test coverage for the Reply functionality by implementing TC-3019. The test verifies: - Sending a message and receiving a reply from another user. - The unread reply indicator appears in the conversation list. - A user can successfully edit their reply message. - A user can edit the original message, and the quote inside the reply accurately reflects these changes. - Interacting with edited URLs inside quoted replies correctly opens them in a new tab. To support these assertions, the page objects were updated: - `conversation.page.ts`: Added `replyQuoteBoxAboveMessageInputField` to verify the quote preview UI disappears during editing. - `conversationList.page.ts`: Added `unreadReplyIndicator` to assert the visibility of the new reply notification icon. Refs: WPB-24828
…C-3019) - Added intermediate `toBeVisible()` assertions after sending/editing messages to ensure the UI state is fully synced and to prevent race conditions. - Fixed a locator issue by removing the `sender` property and adding `.first()` when verifying a user's own outgoing messages - Added an explicit wait to ensure the transient "deleted" placeholder (`You cannot see this message`) disappears before asserting the updated quote text, eliminating flakiness. Refs: WPB-24828
…abilize assertions Refs: WPB-24828
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
The regression test suite was missing a test for the reply flow, specifically for TC-3019: I want to edit my reply.
Solutions
This PR implements the missing automated test for
TC-3019.It ensures users can successfully edit replies and that the UI accurately reflects edits to both replies and original quoted messages. The implemented scenario verifies:
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.