Skip to content

test: remove page plugin "withConnectedUser" [WPB-25038]#21183

Open
markbrockhoff wants to merge 31 commits intodevfrom
mb/remove-withConnectedUser
Open

test: remove page plugin "withConnectedUser" [WPB-25038]#21183
markbrockhoff wants to merge 31 commits intodevfrom
mb/remove-withConnectedUser

Conversation

@markbrockhoff
Copy link
Copy Markdown
Collaborator

@markbrockhoff markbrockhoff commented Apr 30, 2026

TaskWPB-25038 [Web][QA] Investigate race condition caused by parallel connection requests

This is the follow up for #21175 to improve our E2E Tests and prevent race conditions sometimes occurring during login.
The withConnectedUser page plugin could cause a situation where a connection request is sent to a user which doesn't have a device yet.

@markbrockhoff markbrockhoff force-pushed the mb/remove-withConnectedUser branch 5 times, most recently from c3dc025 to 93510b3 Compare April 30, 2026 12:17
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 30, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.94%. Comparing base (6404ff0) to head (d20402b).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev   #21183   +/-   ##
=======================================
  Coverage   44.94%   44.94%           
=======================================
  Files        1704     1704           
  Lines       44893    44893           
  Branches     9395     9395           
=======================================
+ Hits        20178    20179    +1     
  Misses      22419    22419           
+ Partials     2296     2295    -1     
Flag Coverage Δ
app_webapp 43.08% <ø> (+<0.01%) ⬆️
lib_api_client 51.72% <ø> (ø)
lib_core 58.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@markbrockhoff markbrockhoff force-pushed the mb/remove-withConnectedUser branch 9 times, most recently from 36add47 to c078d15 Compare May 8, 2026 11:45
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

🔗 Download Full Report Artifact

🧪 Playwright Test Summary

  • Passed: 15
  • Failed: 0
  • Skipped: 0
  • 🔁 Flaky: 0
  • 📊 Total: 15
  • Total Runtime: 123.0s (~ 2 min 3 sec)

@markbrockhoff markbrockhoff force-pushed the mb/remove-withConnectedUser branch from c078d15 to d20402b Compare May 8, 2026 14:05
@markbrockhoff markbrockhoff marked this pull request as ready for review May 8, 2026 14:06
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 8, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
31.4% Duplication on New Code (required ≤ 5%)

See analysis details on SonarQube Cloud

@markbrockhoff markbrockhoff enabled auto-merge May 8, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants