test: improve stability of tests sending connection requests [WPB-22420]#21185
Merged
markbrockhoff merged 2 commits intodevfrom May 4, 2026
Merged
test: improve stability of tests sending connection requests [WPB-22420]#21185markbrockhoff merged 2 commits intodevfrom
markbrockhoff merged 2 commits intodevfrom
Conversation
markbrockhoff
requested review from
arjita-mitra,
e-maad,
otto-the-bot,
screendriver,
thisisamir98 and
zskhan
as code owners
markbrockhoff
force-pushed
the
mb/improve-connection-request-tests
branch
from
3c04855 to
227b2e9
Compare
JacquelineLehner
previously approved these changes
Apr 30, 2026
markbrockhoff
force-pushed
the
mb/improve-connection-request-tests
branch
from
227b2e9 to
47000ef
Compare
In some cases it could happen that the 1on1 conversation was created after the group conversation causing the test to fail e.g. because the already typed message couldn't be sent
markbrockhoff
force-pushed
the
mb/improve-connection-request-tests
branch
from
47000ef to
25b1602
Compare
It looks like the login button on the page for guests to join via link sometimes ignores clicks if they happen to fast. But sadly this page is out of the control of this repo to improve so a retry will have to do for now
|
Contributor
|
🔗 Download Full Report Artifact 🧪 Playwright Test Summary
specs/Calling/calling.spec.ts (❌ 0 failed,
|
screendriver
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases it could happen that the 1on1 conversation was created after the group conversation causing the test to fail e.g. because the already typed message couldn't be sent