feat: Initial UI for search view(https://wearezeta.atlassian.net/browse/WPB-20721)#21189
Open
arjita-mitra wants to merge 3 commits intodevfrom
Open
feat: Initial UI for search view(https://wearezeta.atlassian.net/browse/WPB-20721)#21189arjita-mitra wants to merge 3 commits intodevfrom
arjita-mitra wants to merge 3 commits intodevfrom
Conversation
arjita-mitra
requested review from
e-maad,
otto-the-bot,
screendriver,
thisisamir98 and
zskhan
as code owners
arjita-mitra
changed the title
arjita-mitra
force-pushed
the
feat/search-filter-sort-drive-WPB-20721
branch
from
4ae2708 to
796b642
Compare
Contributor
|
🔗 Download Full Report Artifact 🧪 Playwright Test Summary
specs/CriticalFlow/groupCalls-TC-8632.spec.ts (❌ 0 failed,
|
e-maad
previously approved these changes
Apr 30, 2026
Contributor
e-maad
left a comment
e-maad
left a comment
There was a problem hiding this comment.
LGTM, added few suggestions
| data-uie-name="full-search-dismiss" | ||
| aria-label={t('fullsearchCancelCloseBtn')} | ||
| onClick={onSearchClear} | ||
| <input |
Contributor
There was a problem hiding this comment.
Did we stop consuming components from react-ui-kit?
|
|
||
| {searchValue && ( | ||
| <CloseIcon | ||
| css={{cursor: 'pointer', flexShrink: 0}} |
Contributor
There was a problem hiding this comment.
Opportunity to move it in css file.
|
|
||
| import {rootHomeIconStyles} from './CellsHeader.styles'; | ||
|
|
||
| export const CellsRootHomeIcon = () => { |
Contributor
There was a problem hiding this comment.
We have all the icons in react-ui-kit
| <div css={tabsWrapperStyles}> | ||
| <div | ||
| aria-hidden={isSharedDriveSearchViewOpen || undefined} | ||
| css={isSharedDriveSearchViewOpen ? tabsHiddenStyles : undefined} |
Contributor
There was a problem hiding this comment.
Suggested change
| css={isSharedDriveSearchViewOpen ? tabsHiddenStyles : undefined} | |
| css={isSharedDriveSearchViewOpen && tabsHiddenStyles} |
Member
There was a problem hiding this comment.
The ternary makes the "apply style vs apply nothing" contract explicit. && relies on truthy/falsy behavior. With Emotion this is usually fine but if typings are narrowed TypeScript could start to complain (false | SerializedStyles).
| css={{marginBottom: 0}} | ||
| onClick={onClickStartAudio} | ||
| onClick={event => { | ||
| currentFocusedElementRef.current = event.target as HTMLButtonElement; |
Contributor
There was a problem hiding this comment.
Do we have to cast it as HTMLButtonElement?
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wire drive initial search view and default view. Epic Link