Simplify Test Build Flags #818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Modify all the test executable `CPPFLAGS` to only have `-DNO_MAIN_LOOP` and `AM_CPPFLAGS`. This removes a lot of duplicate setup of flags for each of the tests. 2. Delete the echoserver's `CFLAGS`. It is just setting the `CFLAGS` for its compile to `AM_CFLAGS` and `AM_CPPFLAGS` which are included by default. 3. Add the macro WS_MAYBE_UNUSED that may be the unused attribute. 4. If INLINE isn't set to some form of inline, set it to WS_MAYBE_UNUSED. 5. Remove redundant ThreadStartNoJoin() macros from the testing header.
JacobBarthelmeh
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify all the test executable CPPFLAGS to only have
-DNO_MAIN_LOOPandAM_CPPFLAGS. This removes a lot of duplicate setup of flags for each of the tests. Cleanup the fallout from that when disabling inlining.