Fix AArch64 assembly syntax causing clang-21 crash #9536
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wolfssl ARM assembly files were mixing ELF syntax (:lo12:) with Darwin syntax (@PAGEOFF) in the same instruction, which causes a clang-21 assembler crash with the error "cannot apply another specifier to MCSpecifierExpr". On Darwin/Apple platforms, @PAGEOFF already represents the low 12 bits of the address, so the :lo12: prefix is redundant and incorrect. This was causing UNREACHABLE assertion failures in AsmParser.cpp when building with pika-26.3-staging toolchain. The fix removes the :lo12: prefix from instructions using @PAGEOFF on Apple platforms in both armv8-sha3-asm.S and armv8-sha512-asm.S.
|
Can one of the admins verify this patch? |
Contributor
|
Hi @kyulee-com, Thanks for letting us know! The code you changed is generated and there are many more places where this fix is required. Sean |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The wolfssl ARM assembly files were mixing ELF syntax (
:lo12:) with Darwin syntax (@PAGEOFF) in the same instruction, which causes a clang-21 assembler crash with the error"cannot apply another specifier to MCSpecifierExpr". On Darwin/Apple platforms,@PAGEOFFalready represents the low 12 bits of the address, so the:lo12:prefix is redundant and incorrect. This was causingUNREACHABLEassertion failures inAsmParser.cppwhen building with clang-21.The fix removes the
:lo12:prefix from instructions using@PAGEOFFon Apple platforms in botharmv8-sha3-asm.Sandarmv8-sha512-asm.S.Testing
Confirmed the build didn't crash with new clang on Mac.