Skip to content

Implement enum/flag parser for struct generation#33

Open
MaxtorCoder wants to merge 15 commits intowowdev:masterfrom
MaxtorCoder:v2_enum_flags
Open

Implement enum/flag parser for struct generation#33
MaxtorCoder wants to merge 15 commits intowowdev:masterfrom
MaxtorCoder:v2_enum_flags

Conversation

@MaxtorCoder
Copy link

  • Implement parsing and usage of new dbdf, dbde and dbdm formats in WoWDBDefs
  • Add some basic tests
  • Some minor optimizations when constructing rows

MaxtorCoder and others added 7 commits March 10, 2026 15:08
@Marlamin
Copy link
Contributor

There are issues loading various tables that don't have flags as a long (aka most) and it fails on converting/casting the values, so that'll need to be solved to actually use the underlying field type.

We'll also need to add some documentation that explains what giving an enumprovider to DBCD does and that returning fields as enum types can lead to the issues that WTL for example has seen with default ToString() behavior changing, and as such it being completely optional with the only change being actual enum/flag types (and more ease around checking them).

We also need to note somewhere that the enum/flag stuff from WoWDBDefs/DBDefsLib can be used through the DBCD provider(s) WITHOUT feeding it to the DBCD constructor, like how WTL uses it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants