Merged
Conversation
krystian-panek-vmltech
requested review from
Copilot and
jakub-przybytek-wttech
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for extracting Makeself self-extracting shell archives on Windows hosts. The change addresses a cross-platform scenario where users configure their SDK to use Unix dispatcher tools (by setting vendor.sdk.os = "unix") but are running on a Windows host where shell scripts cannot be executed directly. The solution extracts the embedded tar.gz archive from the Makeself script by locating gzip magic bytes and unpacking the archive manually.
Key Changes:
- Implemented
UnarchiveMakeselffunction to extract tar.gz archives from Makeself scripts by detecting gzip magic bytes - Added conditional logic in
unpackDispatcherto use manual extraction on Windows hosts when Unix scripts are selected - Fixed log message placement to occur after error checking rather than before
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/sdk.go | Added Windows host detection to extract Unix dispatcher tools using Makeself extraction instead of script execution; fixed log message placement |
| pkg/common/filex/archive.go | Implemented UnarchiveMakeself function to extract tar.gz archives from Makeself self-extracting scripts |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.