Open
Conversation
Document toggleOverlay, loadScript, updateLoadProgressZeroToOne, loadComplete, setEngineInstance, getLobbyInviteLink, deleteRemoteFile, getP2PMaxPayloadSize, and getP2PMaxIncomingMessages. Also add the friends page to the sidebar navigation. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The CLI binds to port 0 (ephemeral) so the OS assigns an available port, rather than hardcoding 7777. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
franzwarning
requested changes
Apr 3, 2026
sdk/lobbies.mdx
Outdated
| WavedashSDK.got_lobby_invite_link.connect(_on_got_invite_link) | ||
|
|
||
| func get_invite_link(): | ||
| WavedashSDK.get_lobby_invite_link() |
Member
There was a problem hiding this comment.
are we sure this exists in the godot repo?
franzwarning
reviewed
Apr 3, 2026
sdk/initialization.mdx
Outdated
| <CodeGroup> | ||
| ```gdscript Godot | ||
| func toggle_overlay(): | ||
| WavedashSDK.toggle_overlay() |
Member
|
go through and make sure these actually exist cuz I think godot (at least) hasn't been updated for a while. double check js and unity too |
- toggle_overlay() → show_overlay() (actual method name in sdk-godot) - Remove get_lobby_invite_link() Godot example (method doesn't exist in sdk-godot) - Remove delete_remote_file() Godot example (method doesn't exist in sdk-godot) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Restore current_stats_received signal connection (was accidentally removed) - Remove store_stats() Godot example (method doesn't exist, stats are stored automatically by set_stat_int(store_now=true) and set_achievement()) - Fix note claiming set_achievement() accepts store_now param in Godot (it doesn't) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Godot: Wavedash. → WavedashSDK. in index.mdx - Unity: lobbyType → lobbyVisibility, sortOrder → sortMethod, localPath → filePath - Unity: remove DeleteRemoteFile example (method doesn't exist) - Unity: fix SetAchievement note (no storeNow param) - JS: add missing P2PConfig fields (messageSize, maxIncomingMessages) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- uploadLeaderboardScore: use positional args, not object - LOBBY_USERS_UPDATED payload: id → userId - LOBBY_MESSAGE payload: id → messageId - Godot backend signal handlers: add missing payload param - UGC_VISIBILITY_PUBLIC → integer 0 (constant doesn't exist in JS SDK) - P2P param table: fix name (data → payload) and order to match signature Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
|
did an audit after installing sdk-unity and sdk-godot locally |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
toggleOverlay,loadScript,updateLoadProgressZeroToOne,loadComplete,setEngineInstance,getLobbyInviteLink,deleteRemoteFile,getP2PMaxPayloadSize,getP2PMaxIncomingMessagessdk/friendsto the sidebar navigation (page existed but was not linked)sdk-jsmain branchResolves ENG-676
Test plan
🤖 Generated with Claude Code