Repository navigation
Reject unverified events only when they carry a key version - #22
Open
santiagomed wants to merge 5 commits into
Open
santiagomed wants to merge 5 commits into
santiagomed wants to merge 5 commits into
Conversation
With reject_unverified enabled (the default), decrypt_event(s) rejected every signed event type that could not be positively verified, including unencrypted messages (no conversation_key_version, never signed) and read receipts, deletes, group and settings changes that arrive without a checkable signature. Clients keeping the default silently lost those events. reject_unverified now: - stays strict for encrypted messages (conversation_key_version set) and key changes: missing signature, no matching signing key, or an invalid signature are rejected; - returns unencrypted messages with key_version None and verified false; - returns other signed event types with verified false when the signature is missing or no matching key is available, and still rejects them when a signature is present but invalid. No API signatures change; set_reject_unverified(false) behaves as before.
…eipts Add deterministic fixture vectors for an unencrypted message and an unsigned read receipt, and pin in every binding suite that both decode under the default reject-unverified policy with verified false.
|
|
kyletruong
approved these changes
Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reject_unverified drops only events that carry a key version. Unsigned and unencrypted events are not dropped by default.