Fix fcitx5 candidate selection commits - #6037
Open
itsXuSt wants to merge 2 commits into
Open
Conversation
Author
|
Validated the updated approach against VS Code's bundled xterm.js on Linux with fcitx5 application preedit disabled. VS Code enables kitty keyboard protocol (useKitty: true), so the candidate-key defer path must still run with kitty enabled. A short keyup fallback delay was also needed so the IME input event can commit the selected candidate before the raw selection key is sent. The verified build preserves Chinese candidate commit for number/space selection in VS Code. |
itsXuSt
force-pushed
the
fix-fcitx5-candidate-commit
branch
from
July 14, 2026 09:29
5dc37ae to
d3171fe
Compare
itsXuSt
force-pushed
the
fix-fcitx5-candidate-commit
branch
from
July 28, 2026 12:23
d3171fe to
18d0cf9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CompositionHelperFixes #6036
Validation
git diff --cached --checkpassed before commitnpm run lint-changesfailed before linting changed files because the current oxlint configuration uses reserved JS plugin nameeslintnpm run buildfailed due to missing existing addon dependencies/types:xterm-wasm-parts,sixel,opentype.js