Preserve fractional scroll offset for pixel-smooth trackpad scrolling - #6039
Open
hmrserver wants to merge 2 commits into
Open
Preserve fractional scroll offset for pixel-smooth trackpad scrolling#6039hmrserver wants to merge 2 commits into
hmrserver wants to merge 2 commits into
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This preserves the fractional viewport offset so trackpad scrolling can move at pixel granularity while rows remain the unit of layout and rendering.
Changes:
_pixelOffset = newRow * cellHeight - scrollTop.devicePixelRatio-roundedtranslateY()on the screen element.will-change: transformso the in-between motion stays on the compositor.beginFrame()boolean with a monotonicclearModelGenerationcounter. With a shared atlas, the boolean can be consumed by the first renderer that sees it; the counter lets each renderer observe and handle model clears independently.Unaffected behavior:
smoothScrollDurationis unchanged; this only affects the fractional offset inside each row step.Demo recording:
BEFORE:
laggy.scroll.mp4
AFTER:
smooth.scroll.mp4