feat: add support and tests for mouse auxiliary buttons (AUX1 to AUX8) - #6044
Open
rajveer3x wants to merge 1 commit into
Open
feat: add support and tests for mouse auxiliary buttons (AUX1 to AUX8)#6044rajveer3x wants to merge 1 commit into
rajveer3x wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for auxiliary mouse buttons (buttons 8–15, such as browser back/forward buttons) and implements the corresponding unit tests to resolve the existing TODO in MouseService.test.ts.
Changes:
MouseService.ts: Mapped ev.button values 3-10 to CoreMouseButton.AUX1-AUX8, and added ev.buttons bitmask checking for drag/move events.
MouseService.test.ts: Added test assertions to cover AUX buttons under DEFAULT, SGR, and SGR_PIXELS protocols.
All unit tests pass and code style is clean. Let me know if you need any adjustments!