Open
Conversation
pantoniou
suggested changes
Oct 13, 2021
pantoniou
left a comment
pantoniou
left a comment
There was a problem hiding this comment.
Minor changes requested to get rid of casts. Otherwise looks good.
| } | ||
| else { | ||
| if (parser.unread != check) { | ||
| if ((int)parser.unread != check) { |
Author
There was a problem hiding this comment.
The cast still needs to be there, to avoid compiler warnings. However, I improved the logic. Please see the new line 187.
nobu
reviewed
Mar 22, 2022
|
|
||
| if ((char *)*end - (char *)*start >= INT_MAX / 2) | ||
| return 0; | ||
| return 0; |
Author
There was a problem hiding this comment.
Yes, it is. Another reason to fully use 4 spaces / tab / {}, so autoformating tools will not struggle
|
Can this go into the master yet? Is there still something remaining, @nobu @pantoniou ? I can help/fix that, if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our toolchain is very pedantic. I fixed several issues it pointed out.