chore: merge main into custom-components-templates

[jwartofsky-yext]

Merges main into 2026-custom-components-templates

Includes all features and fixes from 1.3.0

Test site: https://dev.yext.com/s/1000168938/yextsites/67237/branches/6963/editor#pageSetId=testmerge&locale=en

[coderabbitai]

Walkthrough

This PR introduces directory card title field mapping, a new RepeatedSourceFieldContext for embedded field scoping in mapping editors, and improves multi-value linked entity warnings with context-aware display names. Localization strings are updated across all 24 languages to use new linkedField and resolvedField placeholders, and the dm_directoryChildren schema is expanded with additional metadata fields. A migration handles backward compatibility for existing directory configurations.

Sequence Diagram(s)

sequenceDiagram
  participant User
  participant EmbeddedFieldStringInput
  participant EntityFieldSelector
  participant WarningSystem
  participant Toast

  User->>EmbeddedFieldStringInput: select field from picker
  EmbeddedFieldStringInput->>EntityFieldSelector: onFieldSelect callback
  EntityFieldSelector->>WarningSystem: call warnOnMultiValueLinkedEntityTraversal
  WarningSystem->>WarningSystem: resolve linked/resolved field display names
  alt multi-value linked entity traversed
    WarningSystem->>Toast: show warning with display names
    Toast-->>User: warning message
  else scoped selection
    WarningSystem-->>EntityFieldSelector: no warning
  end

Loading

sequenceDiagram
  participant DirectoryGrid
  participant DirectoryCardsSource
  participant DirectoryCard
  participant CardResolver

  DirectoryGrid->>DirectoryCardsSource: request item source with cardTitle mapping
  DirectoryCardsSource-->>DirectoryGrid: provide resolved cardTitle values
  DirectoryGrid->>CardResolver: syncLinkedSlotMappedCards with children
  CardResolver->>DirectoryCard: create card with data.cardTitle and childRef
  CardResolver->>DirectoryCard: bind cardTitle into HeadingSlot
  DirectoryCard-->>DirectoryGrid: return configured card slot data

Loading

Possibly related PRs

• yext/visual-editor#1216: Changes to warnOnMultiValueLinkedEntityTraversal and linked-entity warning i18n wiring directly overlap with this PR’s warning message updates.
• yext/visual-editor#1215: Related edits to embedded/mapped-field picker scoping and repeated-source propagation.
• yext/visual-editor#1219: Overlapping locale-normalization changes (primaryLocale normalization to BCP-47).

Suggested reviewers

• mkilpatrick
• briantstephan
• benlife5
• asanehisa

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main action of this PR: merging main into the custom-components-templates branch.
Description check	✅ Passed	The description is related to the changeset, explaining that it merges main into the 2026-custom-components-templates branch and includes features from version 1.3.0.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch mergeMainInto2026

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint skipped: no ESLint configuration detected in root package.json. To enable, add eslint to devDependencies.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

🧹 Nitpick comments (1)

packages/visual-editor/src/components/directory/DirectoryWrapper.tsx (1)

79-85: 💤 Low value

Non-null assertion on mappings assumes it's always defined.

Line 79 uses directoryCardsSource.defaultValue.mappings! with a non-null assertion. If createSlottedItemSource doesn't guarantee mappings exists in defaultValue, this could throw at runtime. Consider adding a defensive check or ensuring the type guarantees this.

♻️ Suggested defensive approach

 const getNormalizedDirectoryGridData = (
   value: typeof directoryCardsSource.value | undefined
 ): typeof directoryCardsSource.value => ({
   ...directoryCardsSource.defaultValue,
   ...value,
   field: "dm_directoryChildren",
   constantValueEnabled: false,
   constantValue: [],
   mappings: {
-    ...directoryCardsSource.defaultValue.mappings!,
+    ...directoryCardsSource.defaultValue.mappings,
     ...value?.mappings,
     cardTitle: {
-      ...directoryCardsSource.defaultValue.mappings!.cardTitle,
+      ...directoryCardsSource.defaultValue.mappings?.cardTitle,
       ...value?.mappings?.cardTitle,
       field: value?.mappings?.cardTitle?.field || "name",
     },
   },
 });

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/visual-editor/src/components/directory/DirectoryWrapper.tsx` around
lines 79 - 85, The code unsafely uses a non-null assertion on
directoryCardsSource.defaultValue.mappings and may throw if
defaultValue.mappings is undefined; update the merge to defensively fallback to
an empty object (or a safe default) when accessing
directoryCardsSource.defaultValue.mappings and value?.mappings and similarly
guard cardTitle (e.g., use directoryCardsSource.defaultValue.mappings ?? {} and
value?.mappings ?? {} before spreading, and ensure cardTitle defaults before
reading .field) so that the merge in DirectoryWrapper.tsx (references:
directoryCardsSource, defaultValue, mappings, cardTitle, value) never assumes
mappings exists.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/visual-editor/locales/platform/tr/visual-editor.json`:
- Line 565: The translation for the key "linkedEntityMultiValueWarning" is
incorrect: replace the phrase "ilkini kullanma" with "ilkini kullan" so the
message correctly states that the first linked entity will be used (use the
placeholders {{linkedField}} and {{resolvedField}} as-is); update the value for
linkedEntityMultiValueWarning accordingly to read "{{linkedField}} birden fazla
bağlantılı varlık içerir. {{resolvedField}} için ilkini kullan."

In `@packages/visual-editor/src/editor/EmbeddedFieldStringInput.tsx`:
- Around line 244-248: The onFieldSelect call can send an unscoped resolution
path when getSubDocument(...) returns undefined; compute a resolutionPath =
sourceField ? `${sourceField}.${fieldName}` : fieldName and compute a doc =
sourceField ? getSubDocument(streamDocument, sourceField) : undefined, but if
sourceField is present and doc is undefined, pass streamDocument as the document
arg while still passing the full scoped resolutionPath; update the onFieldSelect
invocation (references: onFieldSelect, sourceField, fieldName, getSubDocument,
streamDocument) to always supply the scoped resolutionPath when sourceField
exists even if the subdocument lookup fails.

---

Nitpick comments:
In `@packages/visual-editor/src/components/directory/DirectoryWrapper.tsx`:
- Around line 79-85: The code unsafely uses a non-null assertion on
directoryCardsSource.defaultValue.mappings and may throw if
defaultValue.mappings is undefined; update the merge to defensively fallback to
an empty object (or a safe default) when accessing
directoryCardsSource.defaultValue.mappings and value?.mappings and similarly
guard cardTitle (e.g., use directoryCardsSource.defaultValue.mappings ?? {} and
value?.mappings ?? {} before spreading, and ensure cardTitle defaults before
reading .field) so that the merge in DirectoryWrapper.tsx (references:
directoryCardsSource, defaultValue, mappings, cardTitle, value) never assumes
mappings exists.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 63f514a9-f9be-418d-bc58-ad02a66adb3d

📥 Commits

Reviewing files that changed from the base of the PR and between 10b43c7 and c9d095d.

⛔ Files ignored due to path filters (4)

• packages/visual-editor/src/components/testing/screenshots/Directory/[desktop] version 77 - City with custom card titles.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
• packages/visual-editor/src/components/testing/screenshots/Directory/[mobile] version 77 - City with custom card titles.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
• packages/visual-editor/src/components/testing/screenshots/Directory/[tablet] version 77 - City with custom card titles.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**
• packages/visual-editor/src/components/testing/screenshots/PhotoGallerySection/[desktop] version 59 with showSectionHeading false.png is excluded by !**/*.png, !packages/visual-editor/src/components/testing/screenshots/**

📒 Files selected for processing (53)

• packages/visual-editor/CHANGELOG.md
• packages/visual-editor/locales/platform/cs/visual-editor.json
• packages/visual-editor/locales/platform/da/visual-editor.json
• packages/visual-editor/locales/platform/de/visual-editor.json
• packages/visual-editor/locales/platform/en-GB/visual-editor.json
• packages/visual-editor/locales/platform/en/visual-editor.json
• packages/visual-editor/locales/platform/es/visual-editor.json
• packages/visual-editor/locales/platform/et/visual-editor.json
• packages/visual-editor/locales/platform/fi/visual-editor.json
• packages/visual-editor/locales/platform/fr/visual-editor.json
• packages/visual-editor/locales/platform/hr/visual-editor.json
• packages/visual-editor/locales/platform/hu/visual-editor.json
• packages/visual-editor/locales/platform/it/visual-editor.json
• packages/visual-editor/locales/platform/ja/visual-editor.json
• packages/visual-editor/locales/platform/lt/visual-editor.json
• packages/visual-editor/locales/platform/lv/visual-editor.json
• packages/visual-editor/locales/platform/nb/visual-editor.json
• packages/visual-editor/locales/platform/nl/visual-editor.json
• packages/visual-editor/locales/platform/pl/visual-editor.json
• packages/visual-editor/locales/platform/pt/visual-editor.json
• packages/visual-editor/locales/platform/ro/visual-editor.json
• packages/visual-editor/locales/platform/sk/visual-editor.json
• packages/visual-editor/locales/platform/sv/visual-editor.json
• packages/visual-editor/locales/platform/tr/visual-editor.json
• packages/visual-editor/locales/platform/zh-TW/visual-editor.json
• packages/visual-editor/locales/platform/zh/visual-editor.json
• packages/visual-editor/package.json
• packages/visual-editor/src/components/directory/Directory.test.tsx
• packages/visual-editor/src/components/directory/Directory.tsx
• packages/visual-editor/src/components/directory/DirectoryCard.tsx
• packages/visual-editor/src/components/directory/DirectoryWrapper.tsx
• packages/visual-editor/src/components/directory/directoryChildReference.test.tsx
• packages/visual-editor/src/components/migrations/0077_directory_card_title_field.ts
• packages/visual-editor/src/components/migrations/migrationRegistry.ts
• packages/visual-editor/src/editor/EmbeddedFieldStringInput.test.tsx
• packages/visual-editor/src/editor/EmbeddedFieldStringInput.tsx
• packages/visual-editor/src/editor/TranslatableRichTextField.test.tsx
• packages/visual-editor/src/editor/TranslatableRichTextField.tsx
• packages/visual-editor/src/editor/yextEntityFieldUtils.test.ts
• packages/visual-editor/src/editor/yextEntityFieldUtils.ts
• packages/visual-editor/src/fields/EntityFieldSelectorField.test.tsx
• packages/visual-editor/src/fields/EntityFieldSelectorField.tsx
• packages/visual-editor/src/fields/TranslatableStringField.test.tsx
• packages/visual-editor/src/fields/TranslatableStringField.tsx
• packages/visual-editor/src/fields/repeatedSourceFieldContext.ts
• packages/visual-editor/src/utils/linkedEntityWarningUtils.test.ts
• packages/visual-editor/src/utils/linkedEntityWarningUtils.ts
• packages/visual-editor/src/utils/normalizeLocale.test.ts
• packages/visual-editor/src/utils/normalizeLocale.ts
• packages/visual-editor/src/utils/resolveYextEntityField.test.ts
• packages/visual-editor/src/utils/resolveYextEntityField.ts
• starter/localData/dev-dm-city-stream__en__8932945.json
• starter/src/dev.config.ts

[pkg-pr-new]

• pages-visual-editor-starter

  npm i https://pkg.pr.new/@yext/visual-editor@1220
  

commit: 67b5574

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/visual-editor/src/editor/EmbeddedFieldStringInput.tsx`:
- Around line 244-250: The code currently passes the full
`${sourceField}.${fieldName}` as the field path even when resolutionDocument is
a scoped child, which breaks lookups against the subdocument; create a new
resolutionFieldPath that is relative to the scoped document (e.g. const
resolutionFieldPath = sourceField ? fieldName : resolutionPath) and call
onFieldSelect?.(resolutionPath, resolutionFieldPath, resolutionDocument) instead
of passing the full path twice; update references to resolutionPath,
resolutionDocument, getSubDocument, and onFieldSelect accordingly.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: b04bff50-eb5f-40c7-9594-ef7e183158a7

📥 Commits

Reviewing files that changed from the base of the PR and between 17087ed and 67b5574.

📒 Files selected for processing (3)

• packages/visual-editor/locales/platform/tr/visual-editor.json
• packages/visual-editor/src/components/directory/DirectoryWrapper.tsx
• packages/visual-editor/src/editor/EmbeddedFieldStringInput.tsx

[briantstephan]

@coderabbitai This PR just represents a merge of our main branch into the 2026-custom-components-templates branch via this temporary merge-main branch. We don't want to introduce changes to what we're pulling in from main since it would make the feature branch unnecessarily diverge from main. We only care about comments that address issues with the merge itself (e.g. improperly resolved merge conflicts, files that are necessary on main but not on the feature branch, etc.).

[coderabbitai]

@briantstephan Understood! I'll limit my review feedback on this PR strictly to merge-related concerns — such as improperly resolved merge conflicts or files that shouldn't differ from main. I'll disregard general code quality, style, or feature-level observations.

Let me go ahead and resolve any existing comments I've already posted on this PR.

---

✏️ Learnings added

Learnt from: briantstephan
URL: https://github.com/yext/visual-editor/pull/1220

Timestamp: 2026-05-20T18:30:47.385Z
Learning: PR `#1220` in yext/visual-editor is a merge-only PR that merges the `main` branch into the `2026-custom-components-templates` feature branch via a temporary branch (`mergeMainInto2026`). For this PR (and similar merge-main-into-feature PRs in this repo), only flag issues related to the merge itself: improperly resolved merge conflicts, files present on main that are missing from the feature branch, etc. Do not post general code review comments (style, logic, missing tests, etc.).

Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.

✅ Actions performed

Comments resolved. Approval is disabled; enable reviews.request_changes_workflow to allow explicit top-level @coderabbitai resolve or @coderabbitai approve commands.