feat(ui): accept optional lng on YouVersionProvider (YPE-5119) - #344
Closed
Dustin-Kelley wants to merge 2 commits into
Closed
feat(ui): accept optional lng on YouVersionProvider (YPE-5119)#344Dustin-Kelley wants to merge 2 commits into
Dustin-Kelley wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: ae2fd0d The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Hosts can set bundled UI copy instead of following the browser locale. When lng is set, skip navigator language detection so Expo can pass its provider locale through the WebView (YPE-5119, unblocks YPE-4820).
cursor
Bot
force-pushed
the
cursor/ype-5119-zh-locale-mapping-72f5
branch
from
August 19, 2026 20:19
c954e39 to
f856dc9
Compare
cursor
Bot
changed the title
Resolve YouVersionProvider test imports: keep main's context probe and this branch's host lng coverage without mocking the hooks provider.
Collaborator
Author
|
Closing in favor of #345. We do not need a second |
Collaborator
Author
|
Superseded by #345. |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes YPE-5119. Unblocks YPE-4820 once Expo forwards its
localeinto the WebView; this web-only change does not fix that ticket by itself.What was wrong
The React web SDK always set UI copy from
navigator.languages. In Expo, Verse of the Day lives in a WebView whose browser language stays English, solocale="es"on the Expo provider never reached headings likeverseOfTheDay.What this does
lngon the UIYouVersionProvider(BCP-47, e.g.esores-MX)lngis set, skipnavigatordetection and use that language for bundled copyverseOfTheDayis used as-isMerged latest
main(oxlint/TypeScript 7, localization sync, and related work).