Skip to content

YPE-5197: Add maxWidth prop to BibleCard for default 700px cap with partner override - (Jira Coding Agent) - #353

Closed
atlassian[bot] wants to merge 1 commit into
mainfrom
YPE-5197-react-web-rn-expo-biblecard-default-max-width-700-with-partner-override-95a11
Closed

YPE-5197: Add maxWidth prop to BibleCard for default 700px cap with partner override - (Jira Coding Agent)#353
atlassian[bot] wants to merge 1 commit into
mainfrom
YPE-5197-react-web-rn-expo-biblecard-default-max-width-700-with-partner-override-95a11

Conversation

@atlassian

@atlassian atlassian Bot commented Aug 24, 2026

Copy link
Copy Markdown

Add a default max width cap of 700px to the BibleCard component's painted shell to match the Swift SDK, ensuring header, scripture, and footer share one consistent measure instead of stretching to fill wide hosts.

Introduce a new optional maxWidth prop to control the shell's maximum width with three modes:

  • Omitted: caps the shell at 700px, inner column fills the shell with only padding inset.
  • Number: caps the shell at the specified pixel value, inner column fills the shell.
  • "100%": makes the shell full-bleed (fills parent), while the inner text column remains capped at 600px to maintain a readable scripture column.

Update documentation and stories to reflect the new maxWidth prop and its usage scenarios.

Add comprehensive tests covering all maxWidth modes and their effects on the shell and inner column widths.

Ensure the card centers itself in wide hosts and fills narrower hosts fully, preserving existing padding and styling.

This change aligns the React Web BibleCard with Swift's layout behavior, provides partners control over card width, and supports full-bleed layouts for specific hosts like Come and See.

Co-authored-by: Cameron Pak <cameron.pak.contractor@youversion.com>
@changeset-bot

changeset-bot Bot commented Aug 24, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: fcf2fd1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@youversion/platform-react-ui Minor
vite-react Patch
@youversion/platform-core Minor
@youversion/platform-react-hooks Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cameronapak cameronapak self-assigned this Aug 24, 2026
@cameronapak

Copy link
Copy Markdown
Collaborator

This was purely an experiment. Closing in favor of #354

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant