YPE-5197: Add maxWidth prop to BibleCard for default 700px cap with partner override - (Jira Coding Agent) - #353
Closed
atlassian[bot] wants to merge 1 commit into
Conversation
Co-authored-by: Cameron Pak <cameron.pak.contractor@youversion.com>
🦋 Changeset detectedLatest commit: fcf2fd1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
|
This was purely an experiment. Closing in favor of #354 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a default max width cap of 700px to the BibleCard component's painted shell to match the Swift SDK, ensuring header, scripture, and footer share one consistent measure instead of stretching to fill wide hosts.
Introduce a new optional
maxWidthprop to control the shell's maximum width with three modes:Update documentation and stories to reflect the new
maxWidthprop and its usage scenarios.Add comprehensive tests covering all
maxWidthmodes and their effects on the shell and inner column widths.Ensure the card centers itself in wide hosts and fills narrower hosts fully, preserving existing padding and styling.
This change aligns the React Web BibleCard with Swift's layout behavior, provides partners control over card width, and supports full-bleed layouts for specific hosts like Come and See.