feat(ui): paint host highlights on scripture surfaces - #140
Open
Dustin-Kelley wants to merge 6 commits into
Open
feat(ui): paint host highlights on scripture surfaces#140Dustin-Kelley wants to merge 6 commits into
Dustin-Kelley wants to merge 6 commits into
Conversation
Subscribe BibleTextView, BibleCard, and VerseOfTheDay at chapter scope and always pass Highlight[] into the DOM so the latch is ready when platform-sdk-react#335 publishes. Co-authored-by: Cursor <cursoragent@cursor.com>
Reset paint from previous-scope state instead of a render-time ref, and stop HighlightsPaint's render-prop from breaking BibleCard memoization. Co-authored-by: Cursor <cursoragent@cursor.com>
Drop the type widen now that the web highlights prop exists. Native still owns fetch so BibleTextView, BibleCard, and VerseOfTheDay paint from the same cache without a token in the WebView. Co-authored-by: Cursor <cursoragent@cursor.com>
Dustin-Kelley
marked this pull request as ready for review
August 19, 2026 16:41
Native sampled today independently of the WebView, so a mount across local midnight could paint highlights for a different passage than the card. Sample once (or use the consumer prop) and always pass dayOfYear into both the lookup and the DOM. Co-authored-by: Cursor <cursoragent@cursor.com>
Collaborator
Author
|
@greptile please review again after my response to your comment |
VOTD paint imports BibleClient from @youversion/platform-core. Name that dependency on the UI package so published installs resolve it without relying on a hoisted copy from core. Co-authored-by: Cursor <cursoragent@cursor.com>
A null Highlight Scope now yields [] instead of every cached row, so stale other-version and other-chapter highlights cannot reach the WebView before today's passage is known. Co-authored-by: Cursor <cursoragent@cursor.com>
Dustin-Kelley
commented
Aug 19, 2026
Collaborator
Author
There was a problem hiding this comment.
This will be another great candidate for Tanstack Query
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BibleTextView,BibleCard, andVerseOfTheDayat chapter scope through the existing native highlights cache, and always pass aHighlight[]into the WebView so controlled paint latches.highlights.@youversion/platform-react-uito 2.7.0 (the published highlights prop from platform-sdk-react#335).Test plan
[]; no fillGreptile Summary
The PR adds paint-only host highlights to
BibleTextView,BibleCard, andVerseOfTheDay, backed by the native chapter-scoped highlights cache.Highlight[].Confidence Score: 5/5
The PR appears safe to merge.
No blocking failure remains.
Important Files Changed
Sequence Diagram
Reviews (5): Last reviewed commit: "fix(ui): do not paint other-scope highli..." | Re-trigger Greptile
Context used: