-
-
Notifications
You must be signed in to change notification settings - Fork 7
fix(broker): recover asyncpg listener after disconnect #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
GefMar
wants to merge
1
commit into
z22092:main
Choose a base branch
from
GefMar:fix/633_worker_broker_startup_recovery
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,6 +1,8 @@ | ||||||
| from abc import ABC, abstractmethod | ||||||
| from typing import Any, Literal, Optional, Sequence | ||||||
|
|
||||||
| BROKER_CHANNEL_LABEL = "__taskiq_postgresql_channel__" | ||||||
|
|
||||||
|
|
||||||
| class QueryBase(ABC): | ||||||
| """Base class for all queries.""" | ||||||
|
|
@@ -219,6 +221,43 @@ def make_query( | |||||
| ) | ||||||
|
|
||||||
|
|
||||||
| class MaxValueQuery(QueryBase): | ||||||
| """Query the greatest value of a column.""" | ||||||
|
|
||||||
| def make_query(self, column: Column) -> str: | ||||||
| """Return a MAX query that uses zero for an empty table.""" | ||||||
| return f"SELECT COALESCE(MAX({column.name}), 0) FROM {self.table_name}" # noqa: S608 | ||||||
|
|
||||||
|
|
||||||
| class SelectAvailableIdsQuery(QueryBase): | ||||||
| """Query available message IDs within a fixed high-watermark.""" | ||||||
|
|
||||||
| def make_query( | ||||||
| self, | ||||||
| primary_key: Column, | ||||||
| labels: Column, | ||||||
| created_at: Column, | ||||||
| ) -> str: | ||||||
| """Return the bounded keyset query for ready messages.""" | ||||||
| return ( | ||||||
| f"SELECT {primary_key.name} FROM {self.table_name} " # noqa: S608 | ||||||
| f"WHERE {primary_key.name} > $1 AND {primary_key.name} <= $2 " | ||||||
| f"AND {labels.name}->>'{BROKER_CHANNEL_LABEL}' = $3 " | ||||||
| f"AND ({labels.name}->>'delay' IS NULL " | ||||||
| "OR EXTRACT(EPOCH FROM " | ||||||
| f"(CURRENT_TIMESTAMP - {created_at.name})) >= CASE " | ||||||
| f"WHEN jsonb_typeof({labels.name}->'delay') = 'number' " | ||||||
| f"THEN trunc(({labels.name}->>'delay')::numeric) " | ||||||
| f"WHEN jsonb_typeof({labels.name}->'delay') = 'string' " | ||||||
| f"AND btrim({labels.name}->>'delay') ~ '^[+-]?[0-9]+$' " | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
I don't think that it is valid to have negative values in this context and should be prohibited, since it just means that no delay should be NULL instead. |
||||||
| f"THEN btrim({labels.name}->>'delay')::numeric " | ||||||
| f"WHEN jsonb_typeof({labels.name}->'delay') = 'boolean' " | ||||||
| f"THEN CASE WHEN ({labels.name}->>'delay')::boolean THEN 1 ELSE 0 END " | ||||||
| "END) " | ||||||
| f"ORDER BY {primary_key.name} LIMIT $4" | ||||||
| ) | ||||||
|
|
||||||
|
|
||||||
| class CreatedAtColumn(Column): | ||||||
| """Column for the created at timestamp.""" | ||||||
|
|
||||||
|
|
||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.