Repository navigation
Conversation
…0p1k patch chain GC/2.0p3 is doldecomp/mweppc's GC_2_0p3: BFBB's source-level 2.0p2 plus the FFCC Japan alias rules (ksa and pwcp from the old patch chain, and two new pointer-like small-data load rules). tools/download_mweppc.py installs it from a pinned mweppc release (RELEASE is None until that release exists). The GC/2.0p1a..k patch scripts are removed: GC/2.0p3 reproduces GC/2.0p1k on 265 of 274 Japanese objects byte for byte and is closer to retail on the rest, and RedSound's objects are identical to GC/2.0p1g's in every region. CMenuPcs::LetterClose and pppFrameYmCheckBGHeight drop the forms that fitted GC/2.0p1k and match in all regions; pppParHitSphMat, pppYmCheckBGHeight and pppYmMoveCircle link in Japan. Japan: +14 / -0 exact functions, +25,320 code and +1,488 data bytes exact, no partial lower. PAL and USA: report unchanged. All DOL checksums pass. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QmcpERTQ1WaRZ73F12eUis
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update: the compiler change moved from doldecomp/mweppc#4 (closed) to PrimeDecomp/mwcc-tools#4, the same change in mwcc-tools'
gc2/. This PR still installs the compiler from an mweppc release (tools/download_mweppc.py); that part needs reworking once mwcc-tools decides how the compiler is distributed. References to mweppc#4 below are historical.Draft: depends on doldecomp/mweppc#4
What changed
GC_2_0p3: BFBB's source-levelGC_2_0p2plus four alias rules measured on FFCC Japan (ksaandpwcpfrom our patch chain, and two new rules: direct small-data loads ofconstglobals, and loads of part of a small literal, are ordered like pointer loads).tools/download_mweppc.pyinstalls it from a pinned mweppc release as a ninja pre-compile step;RELEASEisNoneuntil mweppc publishes a release carrying2.0p3/, so the build stops with a message until then.tools/patch_compiler*.py,tools/aliaspatch_*.py, the CI steps that ran them): nothing else used it.tools/project.pylets a pre-compile step provide a configured compiler (the same hunk as GC/2.5a from mweppc (kss alias rule) for PAL/USA; pppRand vector randomizers match in all regions #17827).CMenuPcs::LetterCloseandpppFrameYmCheckBGHeightdrop the forms written to fit GC/2.0p1k and use the plain source that now matches in every region.pppParHitSphMat,pppYmCheckBGHeightandpppYmMoveCircleareMatchingForJapan too.docs/compiler_baseline.md: new GC/2.0p3 section (rules, measurements, which patch clauses 2.0p2 already covers); the patch-chain sections stay as history.Evidence (fresh baselines at staging 912dd23, report.json, all three regions)
Japan gains
CalcResultOpenAnim,makeFurTex,DrawFur,GbaQueue::LoadPlayerStat/LoadEnemyStat/LoadMapItemStat,CheckHitFaceCylinder,CMapPcs::drawAfter/drawAfterViewer,pppParHitSphMat,pppConstructYmMoveCircle,pppFrameYmCheckBGHeight,SetWorldParamandLetterClose;LoadMapObj77.66 -> 93.32,PickFur98.41 -> 99.41,CalcMainMenuSub99.48 -> 99.98.gbaqueandmenu_letterJapanese data reach 100%.Compiler alone, same source, every Japanese game unit (3081 functions):
265 of 274 Japanese objects are byte-identical to GC/2.0p1k's; the other nine differ only in the improved functions. RedSound objects are byte-identical to GC/2.0p1g's in PAL, USA and Japan.
all_source,progress,report.jsonandok(DOL checksum) pass in all three regions, built with the locally built mweppc compiler packed as a release-format zip and pinned through a temporaryfile://RELEASE (not committed).Why plausible
e3ns,c3a,dsl/dsls/dslu) are already covered by 2.0p2's rules for floating-point literals and small-data stores; an instrumented build shows they never change an answer on top of 2.0p2.LetterClosenow readsm_letterMenuState->listCursoragain fors_BackUpTopPosinstead of astate2local plus a read-back ofs_BackUpCur[0]; Japan reloadsm_letterMenuStateafter the direct store tos_BackUpCur[0], PAL/USA keep one load, from the same source.pppFrameYmCheckBGHeightreadsppvMngfirst instead of between twodirectionstores. Both are 100 in PAL and USA with GC/2.5 as before.Notes
tools/download_mweppc.py(both add it; this version takes the compiler version from the output path, so the merge isVERSIONS = ("GC/2.0p3", "GC/2.5a")with oneRELEASE), inconfigure.py's custom build rules (onedownload_mweppcrule, one pre-compile step per compiler) and indocs/compiler_baseline.md.tools/project.pymerges cleanly.2.0p3/: setRELEASEto the archive URL and SHA-256, rerun the three-region validation, and mark this ready.#ifchain collapses with the new compiler: forcing the PAL/USA arm of every chain into the Japanese build gains no function, as with GC/2.0p1k.🤖 Generated with Claude Code
https://claude.ai/code/session_01QmcpERTQ1WaRZ73F12eUis