0.15.1 release notes: fix std.compress.flate code snippet #568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`streamRemaining` is a method of `std.Io.Reader` (see https://ziglang.org/documentation/0.15.1/std/#std.Io.Reader.streamRemaining), not `std.compress.flate.Decompress`. FWIW, I encountered this error when I tried to use `std.compress.flate.Decompress` in combination with `streamRemaining` in my code. Here's the final code that works on Zig 0.15.2: https://github.com/kaitai-io/kaitai_struct_zig_runtime/blob/d0aee404b6f3a8584ce4df57c52ce0425dc2ab8e/src/root.zig#L519-L526
generalmimon
force-pushed
the
fix-code-snippet-in-0.15.1-relnotes
branch
from
0a04617 to
5f7a5e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
streamRemainingis a method ofstd.Io.Reader(see https://ziglang.org/documentation/0.15.1/std/#std.Io.Reader.streamRemaining), notstd.compress.flate.Decompress.FWIW, I encountered this error when I tried to use
std.compress.flate.Decompressin combination withstreamRemainingin my code. Here's the final code that works on Zig 0.15.2: https://github.com/kaitai-io/kaitai_struct_zig_runtime/blob/d0aee404b6f3a8584ce4df57c52ce0425dc2ab8e/src/root.zig#L519-L526