Skip to content

Align MTORR concentrator constants with Silicon Labs SDK defaults #718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
TheJulianJES wants to merge 1 commit into
base: dev
Choose a base branch
from
+4 −4
Draft

Align MTORR concentrator constants with Silicon Labs SDK defaults #718

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions bellows/ezsp/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,10 @@

EZSP_LATEST = v18.EZSPv18.VERSION
LOGGER = logging.getLogger(__name__)
MTOR_MIN_INTERVAL = 60
MTOR_MAX_INTERVAL = 3600
MTOR_ROUTE_ERROR_THRESHOLD = 8
MTOR_DELIVERY_FAIL_THRESHOLD = 8
MTOR_MIN_INTERVAL = 10
Copy link
Copy Markdown

@zigpy-review-bot zigpy-review-bot May 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches the SiLabs EmberZNet concentrator plugin default (minTimeBetweenBroadcastsSeconds.default=10, valid range 5..60). Note the PR body lists the range as 1..60 -- it's actually 5..60 per plugin.properties. Doesn't change the value, just the range column in the description.

MTOR_MAX_INTERVAL = 60
Copy link
Copy Markdown

@zigpy-review-bot zigpy-review-bot May 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the biggest behavioral shift in the PR: 60x more frequent worst-case MTORR broadcasts than before (3600s -> 60s). The new value matches the SDK default exactly (maxTimeBetweenBroadcastsSeconds.default=60, range 30..300) and the prior 3600 was 12x above the SDK's documented maximum, so this is a correction rather than a tuning change. Worth a release-note line since the on-air broadcast cadence will visibly change for users on large meshes -- SiLabs' networking-concepts doc explicitly warns that small intervals can be overwhelming on large/dense networks, even though their own default is 60s.

MTOR_ROUTE_ERROR_THRESHOLD = 3
MTOR_DELIVERY_FAIL_THRESHOLD = 1
Copy link
Copy Markdown

@zigpy-review-bot zigpy-review-bot May 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aggressive drop from 8 to 1 -- a single delivery failure now triggers MTORR re-broadcast. This is the SiLabs default (deliveryFailureThreshold.default=1) and what zigbee-herdsman uses, so the value is correct. Combined with the MAX_INTERVAL drop, the network becomes substantially more reactive to topology changes; worth calling out alongside #716/#717/#719 in release notes.


UART_PROBE_TIMEOUT = 3
NETWORK_PROBE_TIMEOUT = 7
Expand Down
Loading