Fix styling: active states, focus rings, spinner theming, hairline borders#185
Open
skalthoff wants to merge 1 commit intozotero:masterfrom
Open
Fix styling: active states, focus rings, spinner theming, hairline borders#185skalthoff wants to merge 1 commit intozotero:masterfrom
skalthoff wants to merge 1 commit intozotero:masterfrom
Conversation
…rders - Add :active pressed-state styling to editor toolbar buttons, context menu items, and selection popup wide-button - Remove redundant outline:0 from editor toolbar buttons so base :focus-visible rule applies - Fix context menu focus suppression to only apply on mouse focus, preserving keyboard :focus-visible ring - Add text-align: left on page number input focus for editing feedback - Replace hardcoded spinner colors (#f3f3f3/#7e7e7e) with CSS variables (--fill-quinary/--fill-secondary) for dark mode support - Add 1dppx media query fallbacks for 0.5px borders on range thumb, tool-toggle, split-toggle, and switch knob - Add reusable hairline-border mixin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
:activepressed-state styling to editor toolbar buttons, context menu items, and selection popup wide-buttonoutline: 0from editor toolbar buttons so the base:focus-visiblerule applies:focus-visiblering while still suppressing on mouse focustext-align: lefton page number input when focused for editing feedback#f3f3f3/#7e7e7e) with CSS variables (--fill-quinary/--fill-secondary) for dark mode support1dppxmedia query fallbacks for0.5pxborders on range thumb, tool-toggle, split-toggle, and switch knobhairline-bordermixinAddresses items 1–6 and 8 from #28. Item 7 (zotero-pdf.js#10) is blocked on access to the private repo.
Test plan