Skip to content

feat(validation): add frontmatter schema validator and standalone test suite - #323

Closed
poorvith-mp wants to merge 3 commits into
ARPAHLS:mainfrom
poorvith-mp:feat/frontmatter-validator-and-unit-tests
Closed

feat(validation): add frontmatter schema validator and standalone test suite#323
poorvith-mp wants to merge 3 commits into
ARPAHLS:mainfrom
poorvith-mp:feat/frontmatter-validator-and-unit-tests

Conversation

@poorvith-mp

Copy link
Copy Markdown
Contributor

Summary

  • Added �alidate_frontmatter_dict in skillware/version_policy.py to validate required metadata fields (
    ame, description).
  • Added standalone unit test suite in ests/test_version_and_manifest.py.

Closes #320, closes #321, closes #322.

@rosspeili

Copy link
Copy Markdown
Contributor

Thanks for wanting to help @poorvith-mp, I really appreciate the contribution.

I am going to close PR #323 and issues #320#322 without merging. The work doesn’t match how Skillware is built today, and the PR doesn’t actually implement what those issues describe.

Why we’re closing the issues

Why we can’t accept the PR

The diff adds validate_frontmatter_dict() in version_policy.py but nothing calls it, no loader, CLI, or CI integration, so it doesn’t change runtime behavior. It also doesn’t touch cli.py (#320), doesn’t match our instructions model (#321), and the new tests overlap existing pytest coverage without testing manifest loading (#322). Framework changes here would need wiring, pytest-style tests in the existing files, and a CHANGELOG entry if user-visible.

If you’d like to contribute in this area, a better fit would be a single, focused issue, for example extending manifest or instructions checks in the loader/issuer tests — after reading CONTRIBUTING.md and docs/contributing/ai_native_workflow.md. Happy to review something scoped that way.

@poorvith-mp

Copy link
Copy Markdown
Contributor Author

Thanks for the clear architectural breakdown @rosspeili — makes complete sense regarding manifest.yaml vs instructions separation, PyYAML being a core dependency, and the existing pytest coverage. I'll read through docs/contributing/ai_native_workflow.md and keep any future PRs tightly scoped to existing test patterns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants