Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions skillware/version_policy.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,19 @@ def format_unsupported_message(installed: Version) -> str:
)


def validate_frontmatter_dict(data: dict) -> tuple[bool, str]:
"""Validate skill instructions frontmatter dictionary."""
if not isinstance(data, dict):
return False, "Frontmatter must be a key-value mapping"
name = data.get("name")
if not name or not isinstance(name, str) or not name.strip():
return False, "Missing or empty 'name' field"
desc = data.get("description")
if not desc or not isinstance(desc, str) or not desc.strip():
return False, "Missing or empty 'description' field"
return True, ""


def emit_upgrade_advisory() -> None:
"""Print one dim stderr advisory for unsupported CLI installs; otherwise silent."""
if is_version_check_disabled():
Expand Down
35 changes: 35 additions & 0 deletions tests/test_version_and_manifest.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
import unittest
from packaging.version import Version
from skillware.version_policy import (
should_emit_unsupported_advisory,
format_unsupported_message,
validate_frontmatter_dict,
MIN_UNSUPPORTED,
)


class TestVersionAndManifest(unittest.TestCase):
def test_should_emit_unsupported_advisory(self):
self.assertTrue(should_emit_unsupported_advisory(Version("0.3.0")))
self.assertFalse(should_emit_unsupported_advisory(MIN_UNSUPPORTED))
self.assertFalse(should_emit_unsupported_advisory(Version("0.4.7")))

def test_format_unsupported_message(self):
msg = format_unsupported_message(Version("0.3.0"))
self.assertIn("0.3.0", msg)
self.assertIn("Upgrade to >=", msg)

def test_validate_frontmatter_dict(self):
valid, err = validate_frontmatter_dict(
{"name": "test-skill", "description": "A test skill"}
)
self.assertTrue(valid)
self.assertEqual(err, "")

invalid, err = validate_frontmatter_dict({"name": "", "description": "desc"})
self.assertFalse(invalid)
self.assertIn("name", err)


if __name__ == "__main__":
unittest.main()
Loading