Repository navigation
chore(types): Phase 2 of #415, type config and mail_config - #452
Merged
rosspeili merged 3 commits intoOct 23, 2026
Merged
Conversation
13 tasks
rosspeili
approved these changes
Oct 23, 2026
rosspeili
left a comment
Contributor
There was a problem hiding this comment.
LGTM @UroojFatima-052, merging this one as is. Thanks for this. <3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #415
Phase 2: removes
skillware.core.configandskillware.core.mail_configfrom[[tool.mypy.overrides]]and fixes the 4 errors that surfaced. Typing only, no behavior change.Changes
mail_config.py(validate_addressbook_data):if has_email and isinstance(emails, list):.has_emailalready checks the type, but mypy can't narrow through a separate bool, so the check is repeated inline. Same runtime behavior.mail_config.py(clear_mail_signature_settings):document = dict(_read_yaml(target))._read_yamlreturns a read-onlyMapping, but the function edits it (pop, item assignment). Same patternsave_global_presentation_themealready uses.config.py(_merge_layers): pass a list tomerge_chain_layersinstead of a generator, to match itsSequencesignature. I fixed the call site rather than wideningmerge_chain_layersitself, sincechains_config.pyis outside this phase.pyproject.toml: both modules dropped from the overrides list.CHANGELOG.md: Unreleased entry.Verification
mypy skillware: Success, no issues in 24 filesblack --check/flake8on both files: cleanpytest tests: 588 passed. The only failures aresemantic_web_proxy, which fails locally on a missinglxml_html_cleanpackage and is unrelated to this change.Remaining overrides after this:
skillware.cliandskillware.core.loader(Phase 3 onwards).