Skip to content

chore(types): Phase 2 of #415, type config and mail_config #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rosspeili merged 3 commits into from
Oct 23, 2026
+4 −5
Merged

chore(types): Phase 2 of #415, type config and mail_config #452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d0bcd72
chore(types): fix mypy errors in mail_config (#415)
UroojFatima-052 Oct 22, 2026
5082892
chore(types): pass a list to merge_chain_layers in config (#415)
UroojFatima-052 Oct 22, 2026
52d7956
chore(types): drop config and mail_config mypy overrides (#415)
UroojFatima-052 Oct 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ Contributors add user-facing entries under `[Unreleased]` in the same PR. Mainta
### Changed

- **Skill (`finance/wallet_screening` v2.0.0):** Report schema v2 with `verdict` (`ALLOW` / `REVIEW` / `DENY`), deterministic `risk_level`, `risk_factors[]`, and hop-1 `indirect_exposures` / `risky_counterparties`. Dual-emits `summary.risk_flag` and `summary.total_transactions` for v1 hosts ([#439](https://github.com/ARPAHLS/skillware/issues/439) slice 2).
- **Typing:** `skillware/core/config.py` and `skillware/core/mail_config.py` are now type-clean and removed from the `[[tool.mypy.overrides]]` list, so `mypy skillware` checks them in CI (#415, Phase 2).

## [0.5.9] - 2026-10-20

Expand Down
2 changes: 0 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,8 +274,6 @@ warn_unused_configs = true
module = [
"skillware.cli",
"skillware.core.loader",
"skillware.core.config",
"skillware.core.mail_config",
]
ignore_errors = true

Expand Down
2 changes: 1 addition & 1 deletion skillware/core/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ def _merge_layers(layers: Sequence[ConfigLayer]) -> SkillwareConfig:

mail = merge_mail_settings(mail_layers)
evm = merge_evm_settings(evm_layers)
chains, chains_legacy = merge_chain_layers(layer.data for layer in layers)
chains, chains_legacy = merge_chain_layers([layer.data for layer in layers])
if chains_legacy:
extra = {**extra, "chains": chains_legacy}

Expand Down
4 changes: 2 additions & 2 deletions skillware/core/mail_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -857,7 +857,7 @@ def validate_addressbook_data(data: Mapping[str, Any]) -> List[str]:
)
continue

if has_email:
if has_email and isinstance(emails, list):
valid_email = False
for entry in emails:
if not isinstance(entry, str) or not _EMAIL_RE.match(entry.strip()):
Expand Down Expand Up @@ -1087,7 +1087,7 @@ def clear_mail_signature_settings() -> List[Path]:
for target in (project_config_write_path(), global_config_path()):
if not target.is_file():
continue
document = _read_yaml(target)
document = dict(_read_yaml(target))
mail_block = document.get("mail")
if not isinstance(mail_block, dict):
continue
Expand Down
Loading