Review 2/5 — Content: landing page, /om explanation, strings NO/EN, de-echo - #26
Merged
Merged
Conversation
Review tier 2 of 5 — presentation only, no logic or data changes:
- / becomes a real landing page (was a hard redirect to /org/echo):
product pitch, privacy explanation, org directory, admin login.
- /om explains in plain language what attester.no stores and how
verification works (stored vs never-stored, the hash model, expiry).
- src/strings.ts holds every public-surface string in Norwegian AND
English; ?lang=en switches, Norsk|English toggle on public pages.
Keys for later tiers' pages ship here too (dead until wired).
- Site metadata de-echoed ('attester.no', title template, lang=no),
per-org titles on the form/verify pages, robots.txt.
- src/lib/server/orgs.ts: read-only public org identity (slug, name).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BFHkXUuHJME4cF9AJWbavB
This was referenced Jul 12, 2026
Deploying inf319-certificate with
|
| Latest commit: |
8ec3d36
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://37182449.inf319-certificate.pages.dev |
| Branch Preview URL: | https://claude-review-2-content.inf319-certificate.pages.dev |
The public copy promised automatic deletion (at issuance / after 24h) — neither exists yet. Reworded NO+EN across landing, /om, and the form confirmation: submissions are stored until the organization has reviewed them and issued the certificate, the organization deletes them after issuance, and volunteers can ask the organization to delete their submission. The automatic-deletion copy returns in the retention PR together with the code that makes it true. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BFHkXUuHJME4cF9AJWbavB
ArneeMe
marked this pull request as ready for review
July 21, 2026 17:48
ArneeMe
pushed a commit
that referenced
this pull request
Jul 21, 2026
Merges in review-2-content's latest (retention copy no longer promises automatic deletion) and updates the two E2E tests that still expected the old wording: the form confirmation screen assertion and the /om 'never stored' heading in English. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BFHkXUuHJME4cF9AJWbavB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 2 of the review-ordered stack (now on main after #25 merged). Presentation only — no logic, no data, no security surface. Language-refactor territory: easy approve.
/becomes a real landing page (wasredirect('/org/echo')): pitch, privacy card, org directory (renders without DB), admin login./omexplains what attester.no stores and how verification works — stored vs. never-stored, the hash model, how to verify.src/strings.ts: every public-surface string in Norwegian AND English, typed so the languages can't drift.?lang=en+Norsk|Englishtoggle. Keys for later parts' pages ship here too (dead until wired — so later parts touch strings minimally).attester.no, title template,lang="no"), per-org page titles, robots.txt, read-onlysrc/lib/server/orgs.ts(slug+name only).Verification: typecheck/lint/111 tests/build pass; landing + /om smoke-rendered in both languages (E2E for this lands in part 3).
🤖 Generated with Claude Code
https://claude.ai/code/session_01BFHkXUuHJME4cF9AJWbavB