Make teardown reclamation CI wait for a blocked worker#889
Closed
brandonpayton wants to merge 1 commit into
Closed
Make teardown reclamation CI wait for a blocked worker#889brandonpayton wants to merge 1 commit into
brandonpayton wants to merge 1 commit into
Conversation
This was referenced Jul 11, 2026
Member
Author
|
Additional hosted evidence: naming-only PR #891 reproduced the exact precondition race twice in full Vitest ( |
This was referenced Jul 12, 2026
Member
Author
|
Merged PR #907 supersedes this work through the strengthened serialized-host CI fix now on main at |
This was referenced Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The teardown reclamation test used
onStartedplus a fixed 250 ms delay as a proxy for the guest reachingnanosleep.onStartedfires when the process worker launches, so under CI contentiondestroy()could run while the channel was still idle. In that state the teardown implementation correctly has no blocked channel to wake, and the test falsely reports that no cooperative exit occurred.Subscribe to the kernel worker syscall trace before spawning the fixture and wait until its nanosleep syscall is observed. The trace is drained only after the kernel worker has handled the syscall, making the blocked-channel precondition explicit. Cleanup now also unsubscribes and destroys the host on assertion failures.
This is a test-readiness correction only. Runtime behavior, browser/Node host behavior, ABI, package artifacts, and documentation are unchanged.
Evidence
npm run test:teardown:engines: 3/3 passed on Node/V8 and 3/3 passed on Bun/JavaScriptCore.git diff --checkpassed.hello64.wasmfixture, leaving two tests inwasm64.test.tsunable to start; CI will supply the complete prepared toolchain/workspace.No conformance suites were run because this PR changes test synchronization only, not syscall, process, memory, libc, or runtime semantics.