Skip to content

homebrew: name the generic bottle publisher accurately#891

Closed
brandonpayton wants to merge 1 commit into
mainfrom
chore/homebrew-publish-workflow-name
Closed

homebrew: name the generic bottle publisher accurately#891
brandonpayton wants to merge 1 commit into
mainfrom
chore/homebrew-publish-workflow-name

Conversation

@brandonpayton

@brandonpayton brandonpayton commented Jul 11, 2026

Copy link
Copy Markdown
Member

What this keeps

Rename the Kandelo-owned tap workflow from publish-hello.yml to publish-bottles.yml and change its display name from “Publish hello bottle” to “Publish Kandelo bottles.” The workflow already publishes arbitrary formulas, so the generic name matches what it does.

Relationship to #907

#907 already landed the host-test reliability work that made the old #889 stacked base unnecessary. This PR is now rebuilt directly on current main.

The only unique work left is the workflow filename and display-name correction. I deliberately removed all #889 ancestry and every runtime/test change from the old stacked diff. Workflow inputs, permissions, jobs, and commands are unchanged.

ABI and package impact

There is no Kandelo ABI change, package recipe or revision change, bottle-byte change, VFS image change, binary-index change, or Node/browser runtime change.

Validation

Run through the repository worktree and declared dev shell where applicable:

  • git diff --check origin/main...HEAD — passed.
  • The final diff is one 99%-similar YAML rename with exactly one content line changed.

Not run:

  • A dedicated YAML parser/formatter was not available in the declared dev shell. The workflow body is byte-identical apart from its top-level display-name scalar.
  • Runtime, browser, ABI, package, and conformance suites were not run because no executable workflow logic or platform behavior changed. Hosted PR checks are the integration evidence for GitHub recognizing the renamed workflow file.

@brandonpayton brandonpayton force-pushed the chore/homebrew-publish-workflow-name branch from 008f552 to 64ff3aa Compare July 12, 2026 08:25
@brandonpayton brandonpayton changed the base branch from fix/homebrew-tap-native-sidecars to main July 12, 2026 08:25
@brandonpayton brandonpayton force-pushed the chore/homebrew-publish-workflow-name branch from 64ff3aa to ba4bd28 Compare July 12, 2026 08:59
@brandonpayton brandonpayton changed the base branch from main to fix/teardown-reclaim-readiness July 12, 2026 08:59
@brandonpayton

Copy link
Copy Markdown
Member Author

Hosted stacked-head evidence is now complete for the test suites. On attempt 1, host/test/teardown-reclaim.test.ts passed on the #889 parent; the sole failure was an unrelated SpiderMonkey print(1 + 1) invocation exiting 139 while the rest of that parallel SpiderMonkey suite continued. I reran only the failed jobs. Attempt 2 passed the full Vitest job and test-gate.

This PR remains for maintainer review and is not being auto-merged. Merge order remains #889, then #891.

@brandonpayton

Copy link
Copy Markdown
Member Author

Pre-rewrite record: the stacked head is ba4bd28d3f387272f7e359d73ab32c5b98aa5b52, based on #889. I am reconstructing its one workflow rename directly on current main and will force-push only with a lease against this exact SHA.

@brandonpayton brandonpayton changed the base branch from fix/teardown-reclaim-readiness to main July 13, 2026 17:38
@brandonpayton brandonpayton force-pushed the chore/homebrew-publish-workflow-name branch from ba4bd28 to c9b91dd Compare July 13, 2026 17:38
@brandonpayton

Copy link
Copy Markdown
Member Author

Superseded by #936, which retains this PR as patch-equivalent purpose commits in the consolidated Homebrew publisher batch and reruns the combined validation on current main.

@brandonpayton brandonpayton deleted the chore/homebrew-publish-workflow-name branch July 13, 2026 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant