fix(ifex_ast_introspect): replace undefined TypeException with TypeError - #162
Open
SoundMatt wants to merge 1 commit into
Open
fix(ifex_ast_introspect): replace undefined TypeException with TypeError#162SoundMatt wants to merge 1 commit into
SoundMatt wants to merge 1 commit into
Conversation
`TypeException` is not defined anywhere; the correct built-in is `TypeError`. Calling `get_variant_types()` on a misconfigured Typedef would raise a `NameError` instead of the intended exception. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Matt Jones <47545907+SoundMatt@users.noreply.github.com>
Collaborator
|
Hello @SoundMatt I only saw your many PRs now and will go through them when there is time. I feel that just because an AI model can suggest many small changes, doesn't mean it is worth taking all of it since it creates many modifications that both users/developers have to deal with. If there are many modifications, we may leave a current practical approach of working primarily on master, and prepare a new major-release separately, probably on a working branch first.
I agree this one is easy and has a good explanation, I am just speaking in general since there are so many to look at. Let's take some time to review. |
Collaborator
|
By the way, now that I know which Matt you are, great to see you here! 😊 |
Contributor
Author
|
Happy to support a major release working branch.
This is how we are working with vissr now. In that case we have a 3.2 beta
and a 4.0 alpha.
Kind Regards,
Matt Jones
…On Thu, Jun 25, 2026 at 04:14 Gunnar at MBition ***@***.***> wrote:
*gunnar-mb* left a comment (COVESA/ifex#162)
<#162 (comment)>
By the way, now that I know which Matt you are, great to see you here! 😊
—
Reply to this email directly, view it on GitHub
<#162?email_source=notifications&email_token=ALKX4M7Y2FRWVPSFECCET2D5BUCP5A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINZZHA3DCNRZHA42M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-4798616989>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALKX4M3AO2Y4SEPSXH2DRVL5BUCP5AVCNFSNUABFKJSXA33TNF2G64TZHMZDOOJWGY3TOMJYHNEXG43VMU5TINJQGQ2DAMRZGQ42C5QC>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/ALKX4M3ZHXN5JNTCSKS7X2L5BUCP5A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINZZHA3DCNRZHA42M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJKTGN5XXIZLSL5UW64Y>
and Android
<https://github.com/notifications/mobile/android/ALKX4M6FIVQDWFEEL7AUCRT5BUCP5A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINZZHA3DCNRZHA42M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>.
Download it today!
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Collaborator
|
TypeException appears in more places. Let's fix it everywhere. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeExceptionis not a built-in or defined anywhere in the codebase.Calling
get_variant_types()on a misconfiguredTypedefwouldtherefore raise a
NameErrorinstead of the intended error.Replace with the standard
TypeError.Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com