Conversation
Contributor
|
Can you clear out the unnecessary file for main (like the pngs) and resolve the merge conflicts and I'll take another look at this. |
ConnorNeed
reviewed
Apr 2, 2026
Member
There was a problem hiding this comment.
I don't want to commit the rosbag
Member
There was a problem hiding this comment.
move pid_grapher under HW-Interfaces dir.
| def generate_launch_description(): | ||
| return launch.LaunchDescription( | ||
| [ | ||
| launch_ros.actions.Node( |
| self.plotter_callback, | ||
| 10, | ||
| ) | ||
| self.subscription_targets = self.create_subscription( |
Member
There was a problem hiding this comment.
I think you still need to push you most recent commits since it no longer uses a joint_trajectory
|
|
||
| <exec_depend>python3-matplotlib</exec_depend> | ||
|
|
||
|
|
Member
There was a problem hiding this comment.
Any additional dependancies needed here? eg. sensor_msgs?
Member
There was a problem hiding this comment.
I think this is some kind of rebasing error.
| install*/ | ||
| log/ | ||
| build*/ | ||
| src/kindr |
|
|
||
| upgrade_pkg.tar.* No newline at end of file | ||
| upgrade_pkg.tar.* | ||
| src/kindr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creates the PID graphing package, which is purely a subscription-based node that takes the target and real joint positions, and graphs them using matplotlib. Works on joints 1 - 6 for the rover arm, using the joint states and joint trajectory subscriber