Fix flaky test TestTableTTL::test_base: wait for TTL to be applied#681
Merged
Conversation
koletzilla
changed the title
TestTableTTL::test_base: wait for TTL to be replicated
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to fix flakiness in the ClickHouse TTL integration test (TestTableTTL::test_base) by forcing merges (via OPTIMIZE ... FINAL) and waiting until TTL-driven row removal is observable.
Changes:
- Added a helper (
assert_row_count_after_ttl) that runsOPTIMIZE ... FINALand pollscount(*)until the expected row count is reached (or a timeout occurs). - Updated both the single-node TTL test and the distributed-table TTL test to use the helper instead of single-shot assertions.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
koletzilla
changed the title
TestTableTTL::test_base: wait for TTL to be replicatedTestTableTTL::test_base: wait for TTL to be applied
Contributor
Author
|
Test failing in test_local_matrix to be fixed in #680 |
BentsiLeviav
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix flaky test
TestTableTTL::test_basehttps://github.com/ClickHouse/dbt-clickhouse/actions/runs/28864546139/job/85611192994?pr=680