Fix replace partition error from version >26.6#680
Open
koletzilla wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the insert_overwrite incremental strategy for ClickHouse 26.6+ by conditionally enabling a new server setting required to allow REPLACE PARTITION operations when the source partition is empty on some shards (common in distributed scenarios).
Changes:
- Add
SETTINGS allow_replace_partition_from_empty_source = 1to theREPLACE PARTITIONALTER TABLEstatement when running on ClickHouse >= 26.6. - Document the fix in the changelog under “Unreleased / Bug Fixes”.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| dbt/include/clickhouse/macros/materializations/incremental/incremental.sql | Adds a ClickHouse-version-gated SETTINGS allow_replace_partition_from_empty_source = 1 clause to the REPLACE PARTITION statement used by insert_overwrite. |
| CHANGELOG.md | Adds an Unreleased changelog entry describing the ClickHouse 26.6+ fix for insert_overwrite. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
test_cloud error is another flaky test. Solving it here: #681 |
This was referenced Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the
insert_overwriteincremental strategy failing on ClickHouse 26.6+ withCode: 36 ... refusing REPLACE PARTITION because it would silently drop the destination partition's data. The strategy intentionally replaces partitions from a source table that may have no parts for a partition (to clear shards that received no new data on distributed tables), which newer servers reject by default. TheREPLACE PARTITIONstatement now includesallow_replace_partition_from_empty_source=1on servers 26.6 and newer; older servers keep their existing behavior.I went with the simplest solution: Just add the setting for this specific use case as we explicitly want this one to behave this way. Not touching other queries in case we want to have a different behaviour for them.
Avoided other possible implementations with the focus to keep it simple: