Tredecim Scythe

[Caelic]

the 13th hit guaranteed critical is not coded yet so here it is. wiki says it shouldnt count WS hits and this code follows that, this is just for autoattacks. wiki says it should save hit count when zoning but that will require adding an extra field within the database and i didn't want to clutter the database more to add "cross-zone memory" just seems unimportant. upon zoning the count is just set to 0.

[zach2good]

Interesting find! If you need an example of how to transition this from hard-coded items into mods, I had to do exactly the same thing a while ago here:
https://github.com/DarkstarProject/darkstar/pull/5866/files

[zach2good]

It's not good to hard code specific item IDs in the core, it would be much better to handle this with an item mod

[zach2good]

If the mod was CRIT_ON_HIT_X, you could do:

if (hasMod(CRIT_ON_HIT_X))
    (((CCharEntity*)this)->m_hitCounter)++;

...

if (hasMod(CRIT_ON_HIT_X) && counter % modValue == 0)
    ((CCharEntity*)this)->m_hitCounter = 0;
	 attack.SetCritical(true);

[Caelic]

this is the only item in the game that tracks x hits. if you want to generalize it then you have to set up a memory system so that every item with the mod will remember its own hit counter and not interfere with another item's hit counter. it's an unnecessary amount of work to generalize it if it's the only item that will ever use the latent.

[zach2good]

I wonder if it's worth adding a new member to CCharEntity when only the population that equips the scythe at least once will ever need it, there's nothing else as item-specific in CCharEntity. As much as forever-CharVars are frowned upon, they could be another option to track the hit counter.