[bogdanmariusc10]

🔗 Related Issue

Closes #3950

---

📝 Summary

Fixed a bug in the Admin UI where the "Select All" button for tools, resources, and prompts was selecting ALL items in the system instead of respecting the active search filter.

Problem: When users searched for specific tools/resources/prompts and clicked "Select All", it would select every item in the database rather than just the filtered search results.

Solution:

• Added search query parameter q to three backend endpoints: /admin/tools/ids, /admin/resources/ids and /admin/prompts/ids
• Updated frontend JavaScript selectors to detect and pass the active search term to the backend
• Implemented case-insensitive search across multiple fields (ID, name, description, gateway name)
• Works in both "Add Server" and "Edit Server" modes

Impact: Users can now search for specific items and use "Select All" to select only the filtered results, providing the expected UX behavior.

---

🏷️ Type of Change

• Bug fix
• Feature / Enhancement
• Documentation
• Refactor
• Chore (deps, CI, tooling)
• Other (describe below)

---

🧪 Verification

Check	Command	Status
Lint suite	make lint	✅ Pass
Unit tests	make test	✅ Pass
Coverage ≥ 80%	make coverage	✅ Pass

---

✅ Checklist

• Code formatted (make black isort pre-commit)
• Tests added/updated for changes
• Documentation updated (if applicable)
• No secrets or credentials committed

---

📓 Notes

Backend Changes (mcpgateway/admin.py):

• /admin/tools/ids endpoint (lines 8714-8761)
• /admin/resources/ids endpoint (lines 10058-10107)
• /admin/prompts/ids endpoint (lines 9973-10019)

Frontend Changes (mcpgateway/static/admin.js):

• initToolSelect() function (lines 9976-9980)
• initResourceSelect() function (lines 10420-10423)
• initPromptSelect() function (lines 10851-10854)

Tests Added (tests/unit/mcpgateway/test_admin_ids_search.py):

11 comprehensive unit tests covering:

• Search with query parameter
• Empty search query handling
• Search with gateway filter
• Search with team filter
• Search with no results
• Case-insensitive search
• Combined filters (search + gateway + team)

Technical Details

The fix detects the appropriate search input element based on the context:

Add Server mode: Uses #searchTools, #searchResources, #searchPrompts
Edit Server mode: Uses #searchEditTools, #searchEditResources, #searchEditPrompts

Search is case-insensitive and uses the existing _normalize_search_query() and _like_contains() helper functions for consistency with other search implementations in the codebase.

[crivetimihai]

Nice work on this fix, @bogdanmariusc10 — the core idea of wiring search queries into the Select All endpoints is solid.

During rebase I resolved a couple of conflicts and made some additional fixes worth calling out:

Rebase changes

The monolithic admin.js was split into modules under admin_ui/ in #3137, so I ported your frontend changes to tools.js, resources.js, and prompts.js using the correct search input element IDs from the modular codebase (searchTools/searchEditTools, etc.).

Bugs fixed

1. Duplicate include_inactive filter — the prompts/ids and resources/ids endpoints each applied the enabled.is_(True) WHERE clause twice. Removed the duplicates.

2. Prompt search field mismatch — the prompt IDs endpoint was searching DbPrompt.name, but the HTML partial searches original_name and display_name. This would cause Select All to return different items than the visible filtered list. Updated to match.

3. Team-scope divergence — the IDs endpoints unconditionally included all platform-public items via a hardcoded visibility == "public" OR condition, but the visible list only includes them when the "View Public" checkbox is checked. Added an include_public query parameter (default false) to all three IDs endpoints, mirroring the partial endpoints. The frontend now reads the view-public checkbox and passes include_public=true when appropriate.

Tests added

• 3 new Python tests for the include_public parameter
• 7 JS tests covering search param passing for add/edit modes across all three entity types
• Updated 3 existing regression tests (#3446) to pass include_public=True

Verified

• All 14 Python unit tests pass
• All 166 JS unit tests pass
• E2E tested against a live deployment: search filtering, case insensitivity, team scoping, include_public toggle, backward compatibility, auth enforcement, and SQL injection resistance all confirmed working correctly.