Skip to content

Address some transform-related naming inconsistencies#63

Merged
oschulz merged 9 commits into
masterfrom
renames
Jun 20, 2022
Merged

Address some transform-related naming inconsistencies#63
oschulz merged 9 commits into
masterfrom
renames

Conversation

@oschulz

@oschulz oschulz commented Jun 20, 2022

Copy link
Copy Markdown
Collaborator

We forgot a few additional types and functions when we renamed vartransform to transport_to during the course of #62. This renames them to make things more consistent:

  • Rename VarTransformation to TransportFunction
  • Rename test_vartransform to test_transport
  • Rename NoVarTransform to NoTransport
  • Rename checked_var to checked_arg
  • Rename NoVarCheck to NoArgCheck
  • Rename internal transport helper functions

@oschulz
oschulz requested review from cscherrer and mschauer June 20, 2022 01:13
@oschulz oschulz mentioned this pull request Jun 20, 2022
@github-actions

Copy link
Copy Markdown
Package name latest stable
MeasureTheory.jl

@codecov

codecov Bot commented Jun 20, 2022

Copy link
Copy Markdown

Codecov Report

Merging #63 (90c88f6) into master (648376d) will not change coverage.
The diff coverage is 71.11%.

@@           Coverage Diff           @@
##           master      #63   +/-   ##
=======================================
  Coverage   47.55%   47.55%           
=======================================
  Files          37       37           
  Lines         942      942           
=======================================
  Hits          448      448           
  Misses        494      494           
Impacted Files Coverage Δ
src/transport.jl 63.88% <62.50%> (ø)
src/getdof.jl 87.50% <80.00%> (ø)
src/combinators/power.jl 84.90% <100.00%> (ø)
src/combinators/transformedmeasure.jl 71.42% <100.00%> (ø)
src/interface.jl 96.29% <100.00%> (ø)
src/primitives/dirac.jl 70.58% <100.00%> (ø)
src/primitives/lebesgue.jl 80.95% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 648376d...90c88f6. Read the comment docs.

@oschulz

oschulz commented Jun 20, 2022

Copy link
Copy Markdown
Collaborator Author

Most names changes are straightforward, I think. I'm not sure about checked_var - I rename it to checked_arg here, but maybe that could also be misunderstood? Would checked_variate be better?

@cscherrer

Copy link
Copy Markdown
Collaborator

If it's not very user facing, how about check_support_type?

@mschauer

Copy link
Copy Markdown
Member

I am happy with checked_arg

@oschulz

oschulz commented Jun 20, 2022

Copy link
Copy Markdown
Collaborator Author

If it's not very user facing, how about check_support_type?

It doesn't just check the type, it can also check the size of arrays, etc.

@oschulz

oschulz commented Jun 20, 2022

Copy link
Copy Markdown
Collaborator Author

Are you happy with the state of this @cscherrer ?

@cscherrer

Copy link
Copy Markdown
Collaborator

@oschulz is this a minor or patch release?

@oschulz

oschulz commented Jun 20, 2022

Copy link
Copy Markdown
Collaborator Author

@oschulz is this a minor or patch release?

It'll have to be v0.12, some of these things have docstrings. So probably best to fix these naming inconsistencies now, I'd say.

@oschulz

oschulz commented Jun 20, 2022

Copy link
Copy Markdown
Collaborator Author

Ok, if I go ahead and tag this v0.12 and release it?

@github-actions

Copy link
Copy Markdown
Package name latest stable
MeasureTheory.jl

@oschulz
oschulz merged commit f7b4444 into master Jun 20, 2022
@oschulz
oschulz deleted the renames branch June 20, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants