refactor(Faction): Use game identifiers instead of abbreviations for AoE factions#7813
Open
mbergen wants to merge 18 commits into
Open
refactor(Faction): Use game identifiers instead of abbreviations for AoE factions#7813mbergen wants to merge 18 commits into
mbergen wants to merge 18 commits into
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
hjpalpha
approved these changes
Jul 14, 2026
hjpalpha
reviewed
Jul 14, 2026
hjpalpha
left a comment
hjpalpha
left a comment
Collaborator
There was a problem hiding this comment.
can you test it on one of the craft wikis too?
(just to double-check the commons changes work fine here too)
Collaborator
Author
After getting bamboozled by the data-on-commons setup of these being semi-compatible with our dev envs, seems to work besides some modules not using |
hjpalpha
approved these changes
Jul 14, 2026
Rathoz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates the table keys in AoE faction data to use game identifiers, to align with other wikis.
To facilitate this, normalize game input in Module:Faction, which handles backwards compatibility with non-git usage.
Also removes the FactionData
defaultGame, as it's only usage is now directly usingInfo.defaultGameHow did you test this change?
dev on aoe, sc2